Skip to content

feat: add shared PR workflow skills - #4

Merged
lemarier merged 2 commits into
mainfrom
david/pr-workflow-skills
Sep 11, 2026
Merged

lemarier merged 2 commits into
mainfrom
david/pr-workflow-skills

Conversation

@lemarier

@lemarier lemarier commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Change

Agents need shared guidance for stacked PRs and for handling reviews after opening a PR without occupying the foreground task. Add origin89-gh-stack with GitHub's command and recovery references, MIT license, and Origin89 branch and authorization rules. Link it from the existing working and commit skills so adopting repositories receive it through their normal skills refresh.

Extend the commit skill with background review follow-up for reviews requested for a PR or covered by its automatic review triggers: check every two minutes for at most 30 minutes, verify findings against the current head, address valid feedback within the task's authorization, and clean up on completion, timeout, cancellation, or blockers. Optional mention-only integrations do not hold completion open unless invoked. Fixes and retries retain the original deadline. Add validation scenarios for both workflows.

Validation

  • just check: all 31 tests pass on the rebased branch, including complete skill-bundle installation and local link checks.
  • Skill frontmatter validation passes for the four changed or added skills; git diff --check passes.
  • The scheduled follow-up retrieved inline Codex feedback and published a tested correction. Reviewed task scope, applicable reviewer coverage, deadline handling, and cleanup instructions; the full expiry and cleanup lifecycle remains unverified.

Shared instructions only; no package release or Changeset is needed. Consumers receive the new guidance after merge and their next successful skills refresh.

Copilot AI lite review requested due to automatic review settings September 11, 2026 12:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T12:32:57.884064Z a85752d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8ee9f82c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/origin89-commits/SKILL.md Outdated
Comment on lines +97 to +99
This applies to ordinary PRs and each PR created by a stack submission. Watch
the repository's configured reviewers, including Codex, Copilot, Claude, other
bots, and requested humans; do not stop after the first reviewer responds.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude unrequested Claude reviews from the completion gate

When an adopting repository has the optional @claude workflow installed but the PR contains no explicit mention, Claude does not run by policy (docs/code-review.md:3-5). This instruction nevertheless includes Claude among configured reviewers, while references/pr-review-follow-up.md:51-54 requires any not-triggered reviewer to remain pending, so an otherwise completed ordinary PR will keep its monitor alive until the 30-minute timeout. Determine expected reviewers from the reviewers actually requested or automatically triggered for this PR, rather than from installed configuration alone.

Useful? React with 👍 / 👎.

@lemarier
lemarier merged commit 063bc6f into main Sep 11, 2026
1 check passed
@lemarier
lemarier deleted the david/pr-workflow-skills branch September 11, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants