Repository navigation
test: the periodic test no longer fails across the top of an hour - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestPeriodicJobsRunOnceAcrossLeadersfailed thecanaryCI run of #42 on Postgres 17 (RunOnStart jobs = 2, want 1). It fails whenever it runs across the top of an hour; no library code changes.The test checks that
RunOnStartinserts one job, using a periodic job onEvery(time.Hour). An hourly schedule also has a regular slot at the top of each hour, and the failing package run ended at 02:00:04 UTC after 30 seconds, so the test was running at 02:00:00 and the regular slot inserted a second job. Both jobs were correct.The job now uses a schedule with no slots, so
RunOnStartis the only thing that can insert it.Testing
go test -race -count=3 -run TestPeriodicJobsRunOnceAcrossLeaders .passes against Postgres 17.golangci-lint: 0 issues.Only a test changed, so no
hopperbenchresults.Checklist
make checkpasses — lint and the changed test run locally; the full suite runs in CI hereGODEBUG=fips140=only)docs/PLAN.md— none