Skip to content

test: the periodic test no longer fails across the top of an hour #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giraffesyo merged 1 commit into from
Oct 2, 2026
Merged

test: the periodic test no longer fails across the top of an hour #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion control_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,11 @@ func TestEventsAndStats(t *testing.T) {
}
}

// noSlots is a schedule that never comes due.
type noSlots struct{}

func (noSlots) Next(time.Time) time.Time { return time.Time{} }

func TestPeriodicJobsRunOnceAcrossLeaders(t *testing.T) {
t.Parallel()
h := newHarness(t)
Expand All @@ -456,7 +461,9 @@ func TestPeriodicJobsRunOnceAcrossLeaders(t *testing.T) {
Periodic: []hopper.PeriodicJob{
hopper.Every(time.Second, noop{N: 1}, nil),
hopper.Cron("* * * * * *", noop{N: 2}, &hopper.PeriodicOpts{Name: "cron-seconds"}),
hopper.Every(time.Hour, noop{N: 3}, &hopper.PeriodicOpts{Name: "hourly", RunOnStart: true}),
// No regular slots, so only RunOnStart inserts this one: an
// hourly schedule adds a job when the test spans the hour.
{Name: "on-start", Schedule: noSlots{}, Args: noop{N: 3}, Opts: &hopper.PeriodicOpts{RunOnStart: true}},
},
}
}
Expand Down
Loading