Repository navigation
feat: ROSBag depth_units returns depth images as float32 metres - #187
Merged
Merged
Conversation
depth_units="auto" finds the scale for each depth image: the footer of a RealSense bag, else the unit REP 118 gives for the encoding (16UC1 is millimetres, 32FC1 is metres). A number is the scale in metres per unit. The RealSense SDK writes depth as mono16, which has no unit in REP 118, so without a footer (Intel's sample bags) "auto" does not guess: it returns the image as recorded with a RuntimeWarning. The default is unchanged. Checked against the real bags in bags/. Refs #151 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 35 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
depth_units=None | "auto" | floattoROSBag. A depth image is returned asfloat32metres, and itsdepth_unitsis then 1.0."auto"uses the RealSense footer, else the unit REP 118 gives for the encoding (16UC1millimetres,32FC1metres). A number is the scale in metres per unit. A depth image is a footer-bearing image, or a16UC1/mono16/32FC1image on a topic whose name contains "depth".The RealSense SDK writes depth as
mono16, which REP 118 does not cover, so with no footer (Intel's sample bags)"auto"does not guess: it returns the image as recorded and issues aRuntimeWarning, once per topic. The default (None) is unchanged, and colour is never touched. The docstring explains REP 118.Checked on the real bags in
bags/. Theinvalid_is_nanoption is not in this PR.Refs #151
🤖 Generated with Claude Code