Skip to content

fix(floor): LOW batch 1 — hooks + run markers (6.28.5) - #288

Draft
PrzemekGalarowicz wants to merge 1 commit into
mainfrom
cursor/low-findings-batch-1-fd35
Draft

PrzemekGalarowicz wants to merge 1 commit into
mainfrom
cursor/low-findings-batch-1-fd35

Conversation

@PrzemekGalarowicz

Copy link
Copy Markdown
Contributor

Summary

First delivery pass on the LOW backlog (items L5, L6, L7, L9). Does not merge remaining LOW items; follow-up PRs planned.

Changes

ID Fix
L7 Both pre-write hooks exit 2 on invalid JSON or non-object stdin (no more fail-open {}). enforce-writes-scope uses lstat on pharn.config.json and skips FIFOs.
L5 Symlinked .pharn or symlink scope file → malformed scope (install posture deny-all).
L6 scanRuns() refreshes valid marker mtimes; run-marker.mjs resolves project root (same workTreeRoot / CLAUDE_PROJECT_DIR pattern as hooks).
L9 Scoped writes match declared globs under case fold (pathMatchesScope).

SKILLS_VERSION: 6.28.5

Verification

  • Hook suites updated; new ★ cases for L5/L7/L9
  • node pharn/floor/validate.mjs . → GREEN
  • npm run check:changelog → pass

Remaining LOW (not in this PR)

L1–L4, L8, L10–L22 — separate increments/PRs to follow.

Open in Web Open in Cursor 

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PrzemekGalarowicz
PrzemekGalarowicz force-pushed the cursor/low-findings-batch-1-fd35 branch from 0f577eb to 58891b4 Compare September 28, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants