Fix: _frac calculation using wrong prefix denominator (#2) - #3
Open
Maartje-Cox wants to merge 1 commit into
Open
Fix: _frac calculation using wrong prefix denominator (#2)#3Maartje-Cox wants to merge 1 commit into
Maartje-Cox wants to merge 1 commit into
Conversation
The inner prefix loop overwrote col2 on each iteration, so every _frac column was calculated against LD regardless of its actual letter (H/V/L). Replaced this with a line where letters are directly mapped to the correct prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
The inner
prefixloop in the_fraccalculation overwrotecol2on each pass, sofrac[[col]]only ever used the last prefix (LD), regardless of the actual letter. E.g. V1TG_frac was being calculated as V1TG / LDTG instead of V1TG / VLTG.Replaced the loop with a direct letter-to-prefix mapping (H→HD, V→VL, L→LD) as suggested in the issue.