Skip to content

Fix: _frac calculation using wrong prefix denominator (#2) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maartje-Cox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: _frac calculation using wrong prefix denominator (#2) #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions R/extend_lipo.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,14 @@ extend_lipo_value <- function(lipo){
#note that these values are calculated using only the raw data (df not calc denominator), this is still acceptable since, for example, V1PL_frac can be calculated using V1PL_raw/VLPL_raw
#OR V1PL_raw/(V1PL_raw + V2PL_raw + V4PL_raw + V4PL_raw + V5PL_raw). The denominators should be the same (the raw should be the sum of V1 to V5), sometimes there is a slight discrepancy
#between the raw and adding these parts but it is only slight and due to experimental error
letter_to_prefix <- c(H = "HD", V = "VL", L = "LD")

for (letter in letters) {
for (i in ranges[[letter]]) {
for (suffix in suffixes) {
for (prefix in prefixes){
if (prefix == "ID") next # Skip "ID"
col <- paste0(letter, i, suffix)
col2 <- paste0(prefix, suffix)
frac[[col]] <- round(df[[col]] / df[[col2]], 4) * 100
}
col <- paste0(letter, i, suffix)
col2 <- paste0(letter_to_prefix[[letter]], suffix)
frac[[col]] <- round(df[[col]] / df[[col2]], 4) * 100
}
}
}
Expand Down