Repository navigation
Release v4.14.0: PORTED_FROM v4.14.0; corpus parity results - #113
Merged
Merged
Conversation
Decompile, parse and compile of the game's 32,832 models give the same output and warnings as the Go build of 5c2c147. The decompile note count was stale: v4.13.0 already wrote 5,760 (1,408 light controller notes, the rest for merged meshes), not 1,408.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release prep for v4.14.0, the same steps as #111:
PORTED_FROMis bumped tov4.14.0. Neither #112 nor anything since v4.13.0 touches the decompiler, writer, parser or compiler, so the port itself is unchanged.Corpus parity
The game's 32,832 models, checked against a Go build of
main(5c2c147):cleanmodels compile --cliA stale number, corrected
The README said decompiling gives 1,408 notes. The released v4.13.0 already gives 5,760: 1,408 for light controller 144, and 4,352 for merged meshes, which v4.13.0 introduced. v4.13.0's and
main's decompiled files are byte-identical, so the README number was simply never updated.