Repository navigation
feat(overview): follow the system appearance like the cheat sheet - #268
Merged
Merged
Conversation
The Overview glass was forced to dark. It now follows the system appearance and takes the cheat sheet's core colour (black or white) as an even tint, without the cheat sheet's opaque top band, which veiled the top workspace row's light cards.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The Overview backdrop now follows system light/dark appearance with a subtle matching tint. This is a localized visual change with no changes to capture, window navigation, permissions, or stored data. Notes:
You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Overview's glass was forced to
darkAqua. It now follows the system appearance, like the cheat sheet, and uses the cheat sheet's core colour (black in dark mode, white in light mode) as an even tint. It does not get the cheat sheet's opaque top band. Card title scrims stay black.Two variants were captured in the
defi-e2eVM, in light and dark mode, with fixture windows on two workspaces:Shipped B. In A's light mode, the top workspace row's white cards merge into the near-white band. The cards that spill past the workspace edge keep only a hairline outline, and A's dark mode does the same to dark cards. B keeps every card clearly separated from the backdrop in both appearances.
Evidence
VM captures of the Overview, before (
main) and after (this branch, staged bundle signed like the installed app):Screen Recording granted. Before, the glass stayed dark in light mode. After, it follows the appearance.
Screen Recording denied (card fallback).
overviewPermission=denied. The cards and their titles stay dark. The workspace placeholder (windowBackgroundColor) now follows the appearance.Opening and closing.
fallback(animation:true,…,reduceMotion:true)) and closes in both appearances.started → zoom → presented → completedand the Overview closes, twice in a row.make verifypassed.Proof: VM captures (light and dark, Screen Recording granted and denied, Reduce Motion on and off) and
make verify.Not covered:
NSVisualEffectView.hudWindow, which now also follows the appearance) was not checked on macOS 15; the VM runs macOS 27.Surfaces from the AGENTS.md checklist:
toggle-overview), permissions (Screen Recording granted and denied), and Reduce Motion.CONFIGURATION.mdare unaffected.Merge Danger
Door: two-way
Blast Radius: cosmetic
Only the Overview backdrop's colour changes, and only in light mode. Navigation, focus, and capture are untouched.
Note
Make overview panel glass tint follow system appearance
On macOS 26 and later, the glass effect view in OverviewPanel.swift now uses a 30%-opacity tint that is black under Dark Aqua and white otherwise. This matches the behavior already used by the cheat sheet. Behavioral Change: the explicit Dark Aqua appearance override on the glass view is removed, so the overview panel glass no longer always renders dark.
Macroscope summarized 231a94e.