Skip to content

feat(overview): follow the system appearance like the cheat sheet - #268

Merged
qeude merged 1 commit into
mainfrom
feat/overview-panel-surface
Nov 11, 2026
Merged

qeude merged 1 commit into
mainfrom
feat/overview-panel-surface

Conversation

@qeude

@qeude qeude commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

The Overview's glass was forced to darkAqua. It now follows the system appearance, like the cheat sheet, and uses the cheat sheet's core colour (black in dark mode, white in light mode) as an even tint. It does not get the cheat sheet's opaque top band. Card title scrims stay black.

 NSGlassEffectView .regular
+  tintColor = black 30 % (dark) / white 30 % (light), resolved per appearance
-glassView.appearance = .darkAqua

Two variants were captured in the defi-e2e VM, in light and dark mode, with fixture windows on two workspaces:

  • A: the cheat sheet's gradient (94 % core colour from 0 to 40 %, fading to 0) over the glass and behind the cards, following the appearance.
  • B: the same glass as today, following the appearance, tinted with the core colour, with no band.

A vs B

Shipped B. In A's light mode, the top workspace row's white cards merge into the near-white band. The cards that spill past the workspace edge keep only a hairline outline, and A's dark mode does the same to dark cards. B keeps every card clearly separated from the backdrop in both appearances.

Top row in light mode, A vs B

Evidence

VM captures of the Overview, before (main) and after (this branch, staged bundle signed like the installed app):

  • Screen Recording granted. Before, the glass stayed dark in light mode. After, it follows the appearance.

    Before / after, Screen Recording granted

  • Screen Recording denied (card fallback). overviewPermission=denied. The cards and their titles stay dark. The workspace placeholder (windowBackgroundColor) now follows the appearance.

    Before / after, Screen Recording denied

  • Opening and closing.

    • With Reduce Motion on, the Overview opens without the zoom (fallback(animation:true,…,reduceMotion:true)) and closes in both appearances.
    • With Reduce Motion off, the zoom runs started → zoom → presented → completed and the Overview closes, twice in a row.
  • make verify passed.

Proof: VM captures (light and dark, Screen Recording granted and denied, Reduce Motion on and off) and make verify.

Not covered:

  • The two-display lane did not run.
  • The pre-macOS 26 fallback (NSVisualEffectView .hudWindow, which now also follows the appearance) was not checked on macOS 15; the VM runs macOS 27.

Surfaces from the AGENTS.md checklist:

  • Applied: Overview entry points (opened with toggle-overview), permissions (Screen Recording granted and denied), and Reduce Motion.
  • Did not apply:
    • There is no new option, binding, or default, so Settings, the cheat sheet, and CONFIGURATION.md are unaffected.
    • The docs never mentioned the dark glass.

Merge Danger

Door: two-way

Blast Radius: cosmetic

Only the Overview backdrop's colour changes, and only in light mode. Navigation, focus, and capture are untouched.

Note

Make overview panel glass tint follow system appearance

On macOS 26 and later, the glass effect view in OverviewPanel.swift now uses a 30%-opacity tint that is black under Dark Aqua and white otherwise. This matches the behavior already used by the cheat sheet. Behavioral Change: the explicit Dark Aqua appearance override on the glass view is removed, so the overview panel glass no longer always renders dark.

Macroscope summarized 231a94e.

The Overview glass was forced to dark. It now follows the system appearance and takes the cheat sheet's core colour (black or white) as an even tint, without the cheat sheet's opaque top band, which veiled the top workspace row's light cards.
@github-actions github-actions Bot added the macroscope-review Request a Macroscope review label Nov 11, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 11, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 231a94e

Macroscope's review found this PR approvable — The Overview backdrop now follows system light/dark appearance with a subtle matching tint. This is a localized visual change with no changes to capture, window navigation, permissions, or stored data.

Notes:

  • Macroscope's correctness review did not run, so approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@qeude
qeude merged commit af2a9e6 into main Nov 11, 2026
5 checks passed
@qeude
qeude deleted the feat/overview-panel-surface branch November 11, 2026 16:48
qeude added a commit that referenced this pull request Nov 11, 2026
…heet (#268)" (#269)

The maintainer prefers the Overview as it was: dark glass, no tint.

This reverts commit af2a9e6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant