Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ We agree to restrict the following behaviors in our community. Instances, threat

Tensions can occur between community members even when they are trying their best to collaborate. Not every conflict represents a code of conduct violation, and this Code of Conduct reinforces encouraged behaviors and norms that can help avoid conflicts and minimize harm.

When an incident does occur, it is important to report it promptly. To report a possible violation, **please reach out to the DARA team at RIVM via dara-team-list@rivm.nl.**
When an incident does occur, it is important to report it promptly. To report a possible violation, **please reach out to the SPIN team at RIVM via spin@rivm.nl.**

Community Moderators take reports of violations seriously and will make every effort to respond in a timely manner. They will investigate all reports of code of conduct violations, reviewing messages, logs, and recordings, or interviewing witnesses and other participants. Community Moderators will keep investigation and enforcement actions as transparent as possible while prioritizing safety and confidentiality. In order to honor these values, enforcement actions are carried out in private with the involved parties, but communicating to the whole community may be part of a mutually agreed upon resolution.

Expand Down
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ While the package was originally developed for RIVM (and was previously called D

### 1. Open an issue

**Before submitting any code changes**, please open an issue on the [GitHub issue board](TODO) to:
**Before submitting any code changes**, please open an issue on the [GitHub issue board](https://github.com/rivm-syso/ROvis.table/issues) to:

- Describe the bug you want to fix or the feature you want to add
- Explain why the change is needed
Expand Down Expand Up @@ -127,7 +127,7 @@ Please avoid contributions that:

If you have questions about contributing:

- Open a discussion issue on [GitHub](TODO)
- Open a discussion issue on [GitHub](https://github.com/rivm-syso/ROvis.table/issues)
- Email the SPIN team: [spin@rivm.nl](mailto:spin@rivm.nl)
- Review existing code and documentation in the repository to understand patterns and conventions

Expand Down
95 changes: 0 additions & 95 deletions .gitlab-ci.yml

This file was deleted.

25 changes: 13 additions & 12 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
Package: ROvis.table
Title: ROvis.table is an R package that provides a comprehensive suite of utilities for visualizing in Rijksoverheid style
Version: 0.0.0.9000
Authors@R: person("spin@rivm.nl", email = "spin@rivm.nl", role = c("cre", "aut"))
Description: Provides accessible, keyboard-navigable data tables and themed
visualizations using the gt and DT packages, with RIVM styling guidelines.
Title: Accessible Data Tables with Rijksoverheid Styling
Version: 0.1.0
Authors@R: person("ROvis team", email = "spin@rivm.nl", role = c("cre", "aut"))
Description: Provides accessible, keyboard-navigable data tables and themed
visualizations using the 'gt' and 'DT' packages, with Rijksoverheid styling
guidelines.
License: Apache License (>= 2)
Imports:
Depends:
R (>= 4.5.0)
Imports:
cli (>= 3.6.2),
dplyr (>= 1.1.4),
DT (>= 0.34.0),
Expand All @@ -22,12 +25,10 @@ Suggests:
knitr (>= 1.50),
rmarkdown (>= 2.30),
testthat (>= 3.0.0)
Remotes:
git@github.com:rivm-syso/ROvis.utils.git
Remotes:
rivm-syso/ROvis.utils
VignetteBuilder: quarto
Config/Roxygen2/markdown: TRUE
Config/Roxygen2/version: 8.1.0
Config/testthat/edition: 3
Encoding: UTF-8
Config/roxygen2/version: 8.0.0

Config/roxygen2/markdown: TRUE
Config/roxygen2/version: 8.1.0
48 changes: 28 additions & 20 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,35 @@ export(ro_dt_table)
export(ro_dt_theme)
export(ro_gt_theme)
import(rlang)
importFrom(DT,JS)
importFrom(DT,datatable)
importFrom(ROvis.utils,ro_check_if_font_available)
importFrom(ROvis.utils,ro_color)
importFrom(DT,
JS,
datatable
)
importFrom(ROvis.utils,
ro_check_if_font_available,
ro_color
)
importFrom(cli,cli_abort)
importFrom(dplyr,filter)
importFrom(gt,cell_text)
importFrom(gt,cells_body)
importFrom(gt,cells_column_labels)
importFrom(gt,cells_row_groups)
importFrom(gt,cells_title)
importFrom(gt,cols_align)
importFrom(gt,everything)
importFrom(gt,gt)
importFrom(gt,opt_row_striping)
importFrom(gt,px)
importFrom(gt,sub_missing)
importFrom(gt,tab_options)
importFrom(gt,tab_style)
importFrom(gt,where)
importFrom(gt,
cell_text,
cells_body,
cells_column_labels,
cells_row_groups,
cells_title,
cols_align,
everything,
gt,
opt_row_striping,
px,
sub_missing,
tab_options,
tab_style,
where
)
importFrom(magrittr,"%>%")
importFrom(shiny,HTML)
importFrom(shiny,tags)
importFrom(shiny,
HTML,
tags
)
importFrom(systemfonts,system_fonts)
46 changes: 24 additions & 22 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,24 @@
List all changes in chronological order (new -> old ) to the package here. After release, write release notes and/or a blogpost for the package mailing list and/or pkg down website. This NEWS.md file will be visible in the pkg down website under News > Changelog.

We have chosen to include the headers "Added", "Changed", "Fixed", and "Deprecated". You are free to change these.

GitLab issue numbers are mentioned where applicable.

Sentences start with a capital letter and end with a point.

Use '-' before each entry.

Follow guidelines in documentation of pkgdown::build_news() for version headings.

# ROvis.table v0.0.0.9000

### :sparkles: Added

### :hammer_and_wrench: Changed

### :bug: Fixed

### :coffin: Deprecated

# ROvis.table v0.1.0

First release since `ROvis.table` was split out of the `ROvis` monolith into its own
package, and the repository moved from GitLab to GitHub.

### :sparkles: Added

- `ro_gt_theme()`: RIVM-styled theme for `gt` tables.
- `ro_dt_table()` and `ro_dt_theme()`: accessible, keyboard-navigable `DT` tables.
- Added a "Getting Started" vignette.
- Added community health files: `CONTRIBUTING.md`, `CONTRIBUTORS.md`, and issue and
pull request templates.

### :hammer_and_wrench: Changed

- Migrated the repository from GitLab to GitHub (`rivm-syso/ROvis.table`).
- Replaced GitLab CI with a GitHub Actions workflow covering lint, R CMD check, test
coverage, and pkgdown.

### :bug: Fixed

### :coffin: Deprecated
- Removed the stray `.gitlab-ci.yml` left over from the pre-GitHub setup.

2 changes: 1 addition & 1 deletion R/ROvis.table-package.R
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#' @importFrom cli cli_abort
#' @importFrom dplyr filter
#' @importFrom magrittr %>%
#' @importFrom systemfonts systemfonts
#' @importFrom systemfonts system_fonts
#' @importFrom DT datatable
#' @importFrom gt gt
#' @importFrom ROvis.utils ro_check_if_font_available
Expand Down
1 change: 1 addition & 0 deletions R/ro_dt_table.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#' datatable table to be used with DT
#'
#' @description
#' `r ROvis.utils::ro_group_badge('DT')`
#' Rendering an accessible, keyboard-navigable (with customJS) data table
#' table with options for sorting and page length.
#'
Expand Down
3 changes: 2 additions & 1 deletion R/ro_dt_theme.R
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#' Custom DT Table CSS Styling
#'
#' @description
#' `r ROvis.utils::ro_group_badge('DT')`
#' Returns a Shiny tags object containing custom CSS styles for DT tables,
#' following preliminary RIVM huisstijl.
#' following preliminary Rijksoverheid huisstijl.
#'
#' @importFrom shiny tags HTML
#' @importFrom ROvis.utils ro_check_if_font_available
Expand Down
9 changes: 4 additions & 5 deletions R/ro_gt_theme.R
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
#' Use a standardized theme for gt tables
#'
#' @description
#' `r ro_group_badge('gt')`
#' `r ROvis.utils::ro_group_badge('gt')`
#' This function implements a stylized theme for gt tables.
#'
#' @importFrom gt gt tab_options cols_align sub_missing opt_row_striping tab_
#' style cells_title cell_text cells_column_labels cells_row_groups cells_body
#' everything where px
#' @importFrom gt gt tab_options cols_align sub_missing opt_row_striping
#' tab_style cells_title cell_text cells_column_labels cells_row_groups
#' cells_body everything where px
#' @importFrom systemfonts system_fonts
#' @importFrom ROvis.utils ro_color
#' @importFrom gt gt
#'
#' @param df Dataframe.
#' @param ROfont Default is FALSE, will change to TRUE for next major release (1.0.0).
Expand Down
Loading