Repository navigation
Migration cleanup - #5
Merged
Merged
Conversation
Contributor
Author
|
@Sjonnie404 pretty much identical to rivm-syso/ROvis.utils#3 |
5 tasks done
Contributor
|
@hypebright all looks nice! ❯ checking top-level files ... NOTE All mentioned changes have been implemented. I have one minor question: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration cleanup: GitLab → GitHub, roxygen2 8.1.0, group badges
Will close #6
📘 What is this PR about?
Consistency/cleanup from GitLab → GitHub migration and the split of
ROvis.tableout of theROvismonolith:TBD), switched install instructions fromdevtools::install_gitlab()toremotes::install_github(), removed internalgitlab.rivm.nllinks, and pointed Support/Contributing/License at the SPIN (vs DARA) team contact and community files.CODE_OF_CONDUCT.md: contact changed from the old DARA team to SPIN team..gitlab-ci.ymlfrom the pre-GitHub setup.vignettes/getting-started.qmd(very basicro_gt_theme()andro_dt_table()/ro_dt_theme()examples).v0.1.0entry.DESCRIPTIONversion bumped to match.DESCRIPTIONonConfig/roxygen2/markdown+Config/roxygen2/version. Also fixed a malformed multi-line@importFromthat had accidentally splittab_styleinto two tokens, tolerated by older roxygen2 but rejected by 8.1.0 + a typo importing a non-existentsystemfonts()function instead ofsystem_fonts().man/figures/group-gt.svgandgroup-DT.svg(colors matchROvis.table's own hex sticker)Depends on
github-filesbeing merged intodevelopfirst. This branch was built on top of it (for the community files), so its diff will only be clean once that's in.✅ Checklist
CONTRIBUTING.md🧪 How to test / verify
ℹ️ Extra info
devtools::check()is clean (0 errors, 0 warnings). The one remaining NOTE ("Non-standard file/directory found at top level: 'CONTRIBUTORS.md'") is expected. Need to discuss.