Skip to content

Migration cleanup - #3

Merged
Sjonnie404 merged 8 commits into
developfrom
migration-cleanup
Aug 28, 2026
Merged

Sjonnie404 merged 8 commits into
developfrom
migration-cleanup

Conversation

@hypebright

@hypebright hypebright commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator

Migration cleanup: GitLab → GitHub, roxygen2 8.1.0, group badges

Will close #4

📘 What is this PR about?

Consistency/cleanup from the GitLab → GitHub migration and the split of ROvis.utils out of the ROvis monolith:

  • README: fixed badge placement (was the one repo with badges after the title), removed internal gitlab.rivm.nl links, switched install instructions to remotes::install_github(), added a real Usage example (minimal), and pointed Support/Contributing/License at SPIN (vs DARA) contact and community files instead of template placeholders.
  • NEWS.md: added the v0.1.0 entry. DESCRIPTION version bumped to match.
  • roxygen2 8.1.0: standardized DESCRIPTION on Config/roxygen2/markdown + Config/roxygen2/version (dropped the old duplicate/legacy keys), and fixed 10 stale \link[ROvis]{...} cross-references left over from before the split.
  • Group badges: restored the man/figures/group-*.svg badges used by ro_group_badge(). Colors match each package's own hex sticker.

Depends on github-files being merged into develop first. This branch was built on top of it (for the community files), so its diff will only be clean once that's in.

✅ Checklist

  • I have read contributing guidelines at CONTRIBUTING.md
  • My code follows the style guidelines of this project
  • I have tested these changes and added tests (if applicable)
  • I have added necessary documentation / comments
  • I have linked relevant issues

🧪 How to test / verify

devtools::document()
devtools::test()
devtools::check()
# Confirm badges render:
?ro_color

ℹ️ Extra info

devtools::check() is clean (0 errors, 0 warnings). The one remaining NOTE ("Non-standard file/directory found at top level: 'CONTRIBUTORS.md'") is expected. Need to discuss.

…lates)

Ports the templates from ROvis.ggplot2's feature/checklist_github branch
(matching ROvis.plotly's canonical .github/ layout) to bring this repo in
line with the suite's community-file baseline.

Refs rivm-syso/ROvis#2
@hypebright
hypebright requested a review from Sjonnie404 August 21, 2026 12:03
@hypebright hypebright mentioned this pull request Aug 21, 2026
5 tasks done
@hypebright

Copy link
Copy Markdown
Collaborator Author

@Sjonnie404 pretty much identical to rivm-syso/ROvis.table#5

@Sjonnie404 Sjonnie404 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM

All tests pass

CMD:check gave no issues, only the single note:

❯ checking top-level files ... NOTE
Non-standard file/directory found at top level:
‘CONTRIBUTORS.md’

@Sjonnie404
Sjonnie404 merged commit 67d969f into develop Aug 28, 2026
@hypebright
hypebright deleted the migration-cleanup branch September 16, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DESCRIPTION cleanup ROvis.utils

2 participants