std: make a lot of items crate private by pacak · Pull Request #161612 · rust-lang/rust

pacak · 2026-08-23T17:37:36Z

Enabled warn(unreachable_pub)
Made a lot of things crate private, to the point when doing more required adding exceptions
Removed warn(unreachable_pub)

So now this commit just tightens the current visibility without trying to enforce it.

View all comments

r? clarfonthey

clarfonthey · 2026-08-23T19:32:29Z

So, looking at this, I'm going to nominate this for discussion alongside the clippy lints PR: #161328

Since they should go together, I think.

@rustbot label:I-libs-nominated

pacak · 2026-08-23T19:52:32Z

Sure.

Please no more obscure platform failures, please no more obscure platform failures, please no more obscure platform failures, please no more obscure platform failures...

pacak · 2026-09-09T16:33:30Z

@clarfonthey thoughts? I don't mind keep rebasing it if you need more time to review/decide, but I'm also okay with just closing it - it doesn't really affect me at least at the moment.

clarfonthey · 2026-09-10T12:49:41Z

Sorry, been scatterbrained preparing for rustconf and being at rustconf. Wanted to say essentially, I'm fine unilaterally merging this for non-os/sys modules but would probably want to hold off on those for now.

pacak · 2026-09-10T14:12:04Z

I forgor about the rustconf :)
Ping me when you are ready then.

clarfonthey · 2026-09-10T14:52:04Z

Is all good! I forgor mentioning it. But yeah, I would be fine doing r+ for non os/sys module stuff but would probably hold off on other modules for now.

Most of them don't need to be public, but there are scenarios where thing is private on one platform but public on the other, so having a lint on all the time gets complicated. I enabled the lint, made a lot of things private to the point that dealing with the rest required adding exceptions and disabled the lint back again.

rustbot · 2026-09-10T14:58:14Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

pacak · 2026-09-11T11:41:58Z

Tests are passing. I explicitly allow unreachable_pub in os and sys and removed all the changes to them from this pull request.

clarfonthey · 2026-09-13T18:27:25Z

Thank you! And apologies for taking a while on this one.

@bors r+ rollup

rust-bors · 2026-09-13T18:27:28Z

📌 Commit 081b1b5 has been approved by clarfonthey

It is now in the queue for this repository.

pacak · 2026-09-13T18:33:36Z

No worries.

For the rest - I've been thinking about adding #[warn(unreachable-pub)] inside of os specific modules. Say something is for Linux and comes with #[cfg(target_os = "linux")] or whatever the right syntax is. As far as insides of this module are concerned - there's no other OSes. Does this make sense? Shared stuff stays allowed.

clarfonthey · 2026-09-13T20:13:04Z

So, actually, I kind of want to do the opposite: specifically enabling this lint on target-independent code, since it runs everywhere, but not on target-specific code, which will only selectively lint when it's enabled. But ultimately, the main reason why I didn't want to deal with os/sys for now is that we have other initiatives to refactor those modules and I don't want to do anything major without a larger discussion.

std: make a lot of items crate private 1. Enabled `warn(unreachable_pub)` 2. Made a lot of things crate private, to the point when doing more required adding exceptions 3. Removed `warn(unreachable_pub)` So now this commit just tightens the current visibility without trying to enforce it. r? clarfonthey

Rollup of 5 pull requests Successful merges: - #162732 (Fix unsound dealloc of reborrows from custom allocators) - #154113 (std::net: clamp multicast ttl value to u8 max.) - #161178 (lint ineffective #[unstable] annotations on re-exports) - #161612 (std: make a lot of items crate private) - #162717 (prevent ICE from `derive` on `repr(packed)` enum)

jhpratt · 2026-09-14T01:02:32Z

Looks like there are two things: one case was missed and the lint was left enabled in some spot (despite the PR description).

#162737 (comment)

@bors r-

rust-bors · 2026-09-14T01:02:39Z

This pull request was unapproved.

This PR was contained in a rollup (#162737), which was unapproved.

View changes since this unapproval

rustbot added the O-unix Operating system: Unix-like label Aug 23, 2026

rustbot assigned clarfonthey Aug 23, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 23, 2026