Skip to content

Rollup of 5 pull requests - #162737

Closed
jhpratt wants to merge 27 commits into
rust-lang:mainfrom
jhpratt:rollup-jrgQbk1
Closed

Rollup of 5 pull requests#162737
jhpratt wants to merge 27 commits into
rust-lang:mainfrom
jhpratt:rollup-jrgQbk1

Conversation

@jhpratt

@jhpratt jhpratt commented Sep 13, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

devnexen and others added 27 commits March 19, 2026 20:40
on some platforms the underlying type is c_uchar,
values above 255 would silently truncate.
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Most of them don't need to be public, but there are scenarios where
thing is private on one platform but public on the other, so having a
lint on all the time gets complicated.

I enabled the lint, made a lot of things private to the point that
dealing with the rest required adding exceptions and disabled the lint
back again.
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Fix unsound dealloc of reborrows from custom allocators

- Fixes rust-lang#162719
- Fixes rust-lang#162720
…k-Simulacrum

std::net: clamp multicast ttl value to u8 max.

on some platforms the underlying type is c_uchar,
values above 255 would silently truncate.
std: make a lot of items crate private

1. Enabled `warn(unreachable_pub)`
2. Made a lot of things crate private, to the point when doing more required adding exceptions
3. Removed `warn(unreachable_pub)`

So now this commit just tightens the current visibility without trying to enforce it.

r? clarfonthey
…lkertdev

prevent ICE from `derive` on `repr(packed)` enum

Fixes rust-lang#133025 by not generating the broken impl anymore.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Sep 13, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 13, 2026
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 13, 2026
@jhpratt

jhpratt commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

@bors r+ p=5

@rust-bors

rust-bors Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b776bdf has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 13, 2026
Rollup of 5 pull requests

Successful merges:

 - #162732 (Fix unsound dealloc of reborrows from custom allocators)
 - #154113 (std::net: clamp multicast ttl value to u8 max.)
 - #161178 (lint ineffective #[unstable] annotations on re-exports)
 - #161612 (std: make a lot of items crate private)
 - #162717 (prevent ICE from `derive` on `repr(packed)` enum)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-arm-android failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_literal_escaper test:false 0.255
warning: unreachable `pub` item
   --> library/std/src/process/tests.rs:368:1
    |
368 | pub fn env_cmd() -> Command {
    | ---^^^^^^^^^^^^^^^^^^^^^^^^
    | |
    | help: consider restricting its visibility: `pub(super)`
    |
    = help: or consider exporting it for use by other crates
note: the lint level is defined here

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 14, 2026
@rust-bors

rust-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 738f56f failed: CI. Failed job:

@jhpratt jhpratt closed this Sep 14, 2026
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 14, 2026
@rust-bors

rust-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

PR #161612, which is a member of this rollup, was unapproved.

@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 14, 2026
@jhpratt
jhpratt deleted the rollup-jrgQbk1 branch September 14, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants