Skip to content

Strictly parse numeric hardware parameters - #36

Merged
s2015-turtle merged 1 commit into
mainfrom
fix/strict-numeric-parameters
Sep 9, 2026
Merged

s2015-turtle merged 1 commit into
mainfrom
fix/strict-numeric-parameters

Conversation

@s2015-turtle

Copy link
Copy Markdown
Owner

Summary

  • Validate complete finite numeric values and reject malformed or out-of-range integers before conversion.
  • Bound CAN receive QoS depth to 1–4096.
  • Preserve CAN ID/watchdog base notation and explicitly document whitespace and sign behavior.
  • Include parameter and hardware/joint context in parsing failures.
  • Add regression tests for malformed values, overflow, signs, whitespace, bases, and valid boundaries.

Validation

  • git diff --check passed.
  • Five-distro and vcan CI will validate builds and tests; no local ROS build performed.

Closes #32

@s2015-turtle
s2015-turtle merged commit 5fb6754 into main Sep 9, 2026
6 checks passed
@s2015-turtle
s2015-turtle deleted the fix/strict-numeric-parameters branch September 9, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strictly parse numeric hardware parameters and reject invalid QoS depths

1 participant