Skip to content

Document the license gate and named vulnerability trust entries - #122

Merged
Sahilb315 merged 21 commits into
mainfrom
claude/pensive-sagan-3x8any-vuln-license-docs
Nov 11, 2026
Merged

Sahilb315 merged 21 commits into
mainfrom
claude/pensive-sagan-3x8any-vuln-license-docs

Conversation

@abhisek

@abhisek abhisek commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR documents three Cloud Policy features of the SafeDep pull request check. The spec is docs/specs/2026-11-07-policy-vulnerability-and-license-rules-design.md in safedep/control-tower, on the contract from safedep/api#265.

  • License gate. The scan_gate.licenses setting has three parts: a deny list, an allow list (an empty list turns it off), and unknown (allow, report or fail). A tenant's list replaces the SafeDep default list. SafeDep default policy revision 2 denies nine GPL and AGPL ids, sets no allow list, and sets unknown to allow.
  • Trust scope license. It waives the license findings of one package.
  • Named vulnerability trust entries. --scope vulnerability --vulnerability ID[:justification] waives only the listed ids and their aliases. Each id can carry an optional OpenVEX justification.

Pages

  • governance/cloud/policy/pull-request-checks.mdx:
    • The license settings replace the "fixed rule" text.
    • New how-tos: deny a license, allow only some licenses, fail on an unknown license, waive the license findings of one package, and waive one vulnerability.
    • The example check output matches the server's golden file.
  • governance/cloud/policy/trust-a-package.mdx, overview.mdx and concepts/package-rules.mdx: the new scopes. PMG ignores them.
  • reference/cloud-policy-settings.mdx:
    • the scan_gate.licenses.* settings;
    • the license gate match rules;
    • the license finding kinds;
    • the vulnerabilities field of a package rule;
    • the spellings that fail since default policy revision 2.
  • concepts/policy-resolution.mdx, concepts/policy-revisions.mdx, governance/integrations/github.mdx, governance/integrations/bitbucket-app.mdx and package-security/pmg/cloud-policy.mdx: statements that the change makes wrong.
  • .claude/skills/writing-safedep-docs/products.md: the default policy revision is now 2.

Merge after

This PR is open for internal review and testing. Do not merge it until both of these are done:

  1. safedep/control-tower#1674 merges and is deployed. Before that, the server does not have the license gate or the new scopes.
  2. safedep CLI v0.11.0 is released. It includes Waive named vulnerabilities and licenses, and edit the license gate cli#75.

Checks

  • Each command, flag, YAML shape, limit, finding name and output row was checked against the API protos, the control-tower change, the CLI parser and dry/policy/spdxlicense.
  • mintlify broken-links reports only the three known essentials/ failures.
  • The diff has no em-dashes.

Changes after the docs cleanup

The duplicated-block cleanup is on main (#127). This PR targets main again.

  • Merged the cleanup branch. Resolved the conflicts in two tables, reference/cloud-policy-settings.mdx and governance/cloud/policy/overview.mdx. The new scopes are rows in the new package rule table.
  • One owner page for each fact.
    • The waive how-tos, the OpenVEX justification table and the named vulnerability rules moved from pull-request-checks.mdx to trust-a-package.mdx.
    • Defaults, match rules, license findings and the looser or stricter rules stay in the reference only. The how-to links to them.
  • Fixes from an independent source check:
    • The CLI version notes are removed. The PR merges after the v0.11.0 release, so the pages need no note.
    • A list is compared with the list below it.
    • The license findings table has a Rule cell column and the Reported result.
    • rule create does not accept --scope named-vulnerability.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MhRi597EX9odoSDXbVBsxz

The pull request check now reads a license gate from the cloud policy
(scan_gate.licenses.deny, allow and unknown), and trust entries gain the
scope license and a narrow vulnerability form that names vulnerability ids
with an optional OpenVEX justification. The docs still said that the check
fails on a risky license by a fixed rule, and listed three trust scopes.

- pull-request-checks: add the license gate settings, how the gate decides
  OR, AND and WITH expressions, the default deny list of revision 2 and the
  spellings that now fail, and how-tos to deny a license, allow only some
  licenses, fail on an unknown license, waive the license findings of one
  package and waive one vulnerability. Replace the example policy block
  with the current test data and add the license and named vulnerability
  rows.
- trust-a-package: add the license and named vulnerability scopes and the
  --vulnerability flag.
- overview, package-rules, cloud-policy-settings, policy-resolution,
  policy-revisions: add the new scopes, settings, match rules, findings
  and change directions.
- github, bitbucket-app, pmg/cloud-policy: say that the default policy
  sets the risky license list, that a tenant can change it, and that PMG
  ignores the new scopes and the license gate.
- products.md: update the cloud policy facts for default policy revision 2.

The license scope, --vulnerability and the license gate in policy edit
need a safedep CLI release later than v0.10.0. The pages say so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MhRi597EX9odoSDXbVBsxz
- An allow list fails only a known SPDX license that is not on the list,
  or NONE. A package with no license data or an unknown license passes
  under unknown: allow. Say so in pull-request-checks and in the
  settings reference, and say that unknown: fail allows only the listed
  licenses.
- Cut the match rules and the default policy changes from the how-to.
  Keep the order of evaluation and link to the reference. Move the
  default deny list and the list of spellings that fail since default
  policy revision 2 into the License gate section of the reference.
- github: the default policy also fails on nine GPL and AGPL licenses.
- pull-request-checks: a waived named vulnerability with no
  justification shows the reason only on a private repository.
- cloud-policy-settings: name the column of the stored violation name
  as rule_name in safedep query, table component_policy_violations,
  which shows it.
- trust-a-package: the expansion of --scope all to license holds for a
  safedep CLI release later than v0.10.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MhRi597EX9odoSDXbVBsxz
@abhisek
abhisek marked this pull request as ready for review November 9, 2026 06:48
@safedep

safedep Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

View complete scan results →

This report is generated by SafeDep GitHub App

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T17:28:50.425548Z 5e21bb1 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sahilb315 and others added 8 commits November 9, 2026 18:46
- Merge Shadow AI into Generate an AI BOM; remove AI Governance router
- Merge Dependency Usage into Code Analysis
- Merge Talk to SafeDep into Investigate with an AI Agent
- Split Cloud SQL into a reference page and a Query with SQL how-to
- Move Malware Analysis, Scan Catalog, vet FAQ, Build Your Own Queries
- Add redirects for every old URL and update inbound links
- Regenerate docs-ia.md section 7 from docs.json

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Move the merged AI BOM content to /governance/shadow-ai-detection
- Title "Detect Shadow AI in Code"; sections Detect shadow AI, Generate the AI BOM
- Restore the AI Visibility group; /governance/vet/ai-bom redirects here

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Restore /governance/ai-governance and its redirects
- Restore the "Govern AI usage" card on the AI Agent Security overview

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	governance/cloud/overview.mdx
#	governance/cloud/quickstart.mdx
#	governance/shadow-ai-detection.mdx
- key not found fix: owner is pmg/cloud-policy, quickstart links to it
- Cloud cooldown precedence: owner is pmg/cloud-policy settings table
- Container CA trust: owner is kernel-enforcement, github-actions links to it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Enforcement matrix: owner is the settings reference
- Override steps: pull request checks links to Target a Group
- Auth and sync errors: owner is Cloud Troubleshooting
- vet credentials: inventory links to Authentication
- Threat Intel JSON rules: owner is the schema page

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main added sidebar titles (#123) and fixed factual errors (#124).
Two files conflicted in the frontmatter only:

- governance/cloud/policy/pull-request-checks.mdx: keep the title and
  description of this branch, which name the license gate, and add the
  sidebarTitle "Gate Pull Requests" from main.
- governance/cloud/policy/trust-a-package.mdx: keep the description of
  this branch, which lists the scope license, and add the sidebarTitle
  "Trust a Package" from main.

Main added no other text about trust scopes or license checks, so no
other page needed an update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MhRi597EX9odoSDXbVBsxz
# Conflicts:
#	governance/cloud/policy/overview.mdx
#	reference/cloud-policy-settings.mdx
@Sahilb315
Sahilb315 changed the base branch from main to refactor/dedupe-pmg-blocks November 10, 2026 08:26
Sahilb315 and others added 3 commits November 10, 2026 14:05
- Move the waive how-tos and the OpenVEX table to Trust a Package
- Link to the reference for defaults, match rules, findings and looser or stricter changes
- Replace the project sync command with a link to Label projects

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Say that the policy commands need a CLI release later than v0.10.0
- Say that a list is compared with the list below it
- Add the Rule cell and the Reported result to the license findings
- Say that rule create does not accept --scope named-vulnerability

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	governance/vet/code-analysis.mdx
@Sahilb315
Sahilb315 changed the base branch from refactor/dedupe-pmg-blocks to refactor/land-dedupe-blocks November 10, 2026 08:42
Sahilb315 and others added 4 commits November 10, 2026 14:18
…o claude/pensive-sagan-3x8any-vuln-license-docs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Put each CLI version note before the first command on its page
- Say that the no-value rule does not apply to license lists
- Say that a justification is split off only when it is a known name
- Name the license gate as part of the scan gate
- Point the GitHub App page to Risky Licenses, not "above"
- Make the CLI version line in products.md complete

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Sahilb315
Sahilb315 changed the base branch from refactor/land-dedupe-blocks to main November 10, 2026 10:17
Sahilb315 and others added 4 commits November 10, 2026 15:47
# Conflicts:
#	governance/cloud/policy/overview.mdx
#	reference/cloud-policy-settings.mdx
- Remove the notes on trust-a-package and pull-request-checks
- products.md: the policy commands need safedep CLI v0.11.0 or later

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Sahilb315
Sahilb315 merged commit 6b8054f into main Nov 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants