Fix issues related to RAP tracking - #1364
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
- Coverage 72.60% 72.57% -0.04%
==========================================
Files 301 301
Lines 26286 26279 -7
Branches 3700 3702 +2
==========================================
- Hits 19086 19072 -14
- Misses 5650 5654 +4
- Partials 1550 1553 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
CHrlS98
requested changes
Oct 1, 2026
CHrlS98
left a comment
Contributor
There was a problem hiding this comment.
Looks good, here are a few comments. Can you share some example data for testing?
CHrlS98
approved these changes
Oct 5, 2026
CHrlS98
left a comment
Contributor
There was a problem hiding this comment.
Tested with fibercup data, good to go @arnaudbore
arnaudbore
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
Added/Improved warnings related to RAP tracking.
Fixed an issue where step size did not change as intended during RAP tracking.
Replaced min_nbr_points and max_nbr_points by min_length and max_length in the Tracker class.
Merged Propagator on Sphere and ODF Propagator into one single class.
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist