Skip to content

Fix issues related to RAP tracking - #1364

Merged
arnaudbore merged 5 commits into
scilus:masterfrom
anaislanthier:rap_tracking_issues
Oct 5, 2026
Merged

arnaudbore merged 5 commits into
scilus:masterfrom
anaislanthier:rap_tracking_issues

Conversation

@anaislanthier

@anaislanthier anaislanthier commented Sep 30, 2026 •

Copy link
Copy Markdown

Quick description

Added/Improved warnings related to RAP tracking.
Fixed an issue where step size did not change as intended during RAP tracking.
Replaced min_nbr_points and max_nbr_points by min_length and max_length in the Tracker class.
Merged Propagator on Sphere and ODF Propagator into one single class.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.57%. Comparing base (aa4b761) to head (f34b97a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage   72.60%   72.57%   -0.04%     
==========================================
  Files         301      301              
  Lines       26286    26279       -7     
  Branches     3700     3702       +2     
==========================================
- Hits        19086    19072      -14     
- Misses       5650     5654       +4     
- Partials     1550     1553       +3     
Flag Coverage Δ
smoketests 69.73% <62.50%> (-0.04%) ⬇️
unittests 14.22% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.28% <21.42%> (-0.07%) ⬇️
Library 69.32% <84.61%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CHrlS98 CHrlS98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, here are a few comments. Can you share some example data for testing?

Comment thread src/scilpy/cli/scil_tracking_local_dev.py Outdated
Comment thread src/scilpy/cli/scil_tracking_local_dev.py Outdated
Comment thread src/scilpy/cli/scil_tracking_local_dev.py
Comment thread src/scilpy/cli/scil_tracking_local_dev.py Outdated
Comment thread src/scilpy/cli/scil_tracking_local_dev.py Outdated
Comment thread src/scilpy/tracking/rap.py Outdated
Comment thread src/scilpy/tracking/rap.py Outdated
Comment thread src/scilpy/tracking/tracker.py Outdated
Comment thread src/scilpy/tracking/tracker.py Outdated
Comment thread src/scilpy/tracking/tracker.py Outdated

@CHrlS98 CHrlS98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with fibercup data, good to go @arnaudbore

@arnaudbore
arnaudbore added this pull request to the merge queue Oct 5, 2026
Merged via the queue into scilus:master with commit 588a49a Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants