Repository navigation
BitEmbedding from utf8-tokenizer instead of WeLT's own copy - #79
Merged
Merged
Conversation
AmitMY
force-pushed
the
simplify/cleanup
branch
from
October 10, 2026 09:12
af2e0eb to
a8be73a
Compare
AmitMY
force-pushed
the
simplify/bit-embedding
branch
from
October 10, 2026 09:12
b350f29 to
fb5beef
Compare
AmitMY
force-pushed
the
simplify/cleanup
branch
from
October 11, 2026 09:39
a8be73a to
ac765c6
Compare
The same module (a byte table plus a projection of each byte's bits, folded for export), with the same parameter names, so checkpoints load unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
…TERN renamed in both) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
AmitMY
force-pushed
the
simplify/bit-embedding
branch
from
October 11, 2026 09:39
fb5beef to
bef353f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #78.
BitEmbedding from utf8-tokenizer
WeLT's
ByteEmbedding(a byte table plus a zero-initialized projection of each byte's bits, folded into a plain table for export) moved to utf8-tokenizer asBitEmbedding(sign/utf8-tokenizer#14, released in 0.8.4). WeLT now imports it.The parameter names are the same (
weight,bit_proj), so existing checkpoints load unchanged.The dependency is
utf8-tokenizer[fast]>=0.8.5withwords-segmentation>=0.0.7: 0.8.5 renamed the control-tokens pattern words-segmentation uses (sign/utf8-tokenizer#16, sign/words-segmentation#9).Tests
With 0.8.4 installed,
test_model.py,test_model_overfitting.py,test_processor.pyandtest_train.pypass (train → export → vLLM generation): 40 passed, 1 skipped. The Docker image needs a rebuild to pick up 0.8.4.🤖 Generated with Claude Code
https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
Note
Low Risk
Localized embedding swap with compatible parameter names; main risk is version skew if environments don’t pick up the bumped tokenizer/segmentation deps.
Overview
Removes WeLT’s in-repo
ByteEmbeddingand wires byte embeddings throughBitEmbeddingfromutf8-tokenizerfor the bytes encoder and decoder.Dependency floors move to
words-segmentation>=0.0.7andutf8-tokenizer[fast]>=0.8.5(aligned control-token naming).weightandbit_projare unchanged, so existing checkpoints should load without migration.Reviewed by Cursor Bugbot for commit bef353f. Bugbot is set up for automated code reviews on this repo. Configure here.