Repository navigation
fix: repair Node 22 crawling, close the unreviewed-publish path, stop workers pushing schema - #160
Merged
Merged
Conversation
A whole-project audit, reviewed by a three-model council over seven rounds. - Crawl with undici's own fetch: the built-in fetch rejects an undici 8 dispatcher on Node 22 and 24. - Gate `approved` and `published` to reviewed predecessors; close the `informationGain` create hole; refuse article and evidence-source deletes. - Stamp `publishedAt` and clear the used `publishAt` on every publish. - Turn off the dev schema push for all three queue workers. - Keep mock runs mock (crawler and fallback LLM client follow the run's mode); fail live research without an Ahrefs key instead of crawling demo hosts. - Fix the 015044 migration's down, the override/send-back/reset QA and audit writes, topic removal during a run, webhook error redaction, seed password resets, obsolete suggestions, and expiring demo evidence dates. - Matcher: whole-word number words, decades, and `2000` vs `2,000`. - Docs, env examples, test config (jsdom only where needed, mock pinned), and lint config corrected; superseded migration snapshots pruned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
snowopsdev
added a commit
that referenced
this pull request
Nov 10, 2026
…dead files (#162) The test suites could quietly wreck a working database, the Playwright suite ran nowhere, and the repo carried 25 MB of things nothing uses. This closes the test, CI and hygiene findings from the project audit (follow-up to #160). **Tests and CI** - The CMS integration and Playwright suites refuse to start unless the `DATABASE_URL` database name contains `test`, or `DATUM_TEST_DATABASE_OK=true` is set. They rewrite workspace state and add append-only rows, and `cms/.env` (usually your working database) is loaded by default. A missing `DATABASE_URL` is refused too. **If you run the suites against a per-worktree database whose name lacks `test`, rename it or set the opt-in.** - New `e2e` CI job: migrate, seed (dev push off), install Chromium, run the 10 Playwright specs. CI databases are now `datum_test`. - CI cancels superseded runs only on pull requests, not on `main`. - The redirect spec asserts the 307 itself (it passed only by accident while signed out). The admin-performance and admin-nav specs wait for hydration before interacting; a click on a cold dev server was being lost. Four integration assertions that could not fail now can. **Hygiene** - Removed: the vendored Cursor `pstack` plugin (`vendor/claude-plugins`, MIT, install it per user from upstream if wanted), the 96 audit screenshots and capture log (in history at `7bb204f`), and the two shipped plans. - `graphify-out/` is no longer tracked and `.gitattributes` (a merge driver only one machine had) is gone. **After pulling, existing clones lose their local graph files; run `graphify update .` to rebuild.** CONTRIBUTING now says not to run `graphify hook install`, which recreates that driver. - Media uploads accept raster images only (SVG or HTML uploads were served from the app origin). - Smaller: `DESIGN.md` scoped to the public reader, `cms/.vscode` paths fixed, dead and duplicate `ops.css` rules removed, narrower database reads on the setup hub and suggestion scan, stale "board" wording and `configFingerprint` docs corrected, `docs/open-source-checklist.md` removed. **Proof:** typecheck, lint (0 warnings), pipeline 883/883, CMS integration 850/850 and `npm run build --workspace cms` on this branch; the full Playwright suite 59/59 against Playwright's own dev server on a freshly migrated and seeded test database, plus the admin and performance specs repeated cold with no retries. The guard's test fails with the guard disabled, and each strengthened assertion was shown to fail against broken code. The new `e2e` job itself first runs here. Reviewed with sol-loop: 2 rounds with GPT-6.1 Sol. Sol verdict: approved. Each workstream was also reviewed by Claude Opus 5.5 before integration. Created with Claude Opus 5.5 in Claude Code; workstreams implemented by Claude Sonnet 5.5 subagents. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A read of the whole project turned up real breakage: live page crawling failed on the Node versions CI and
enginestarget, any signed-in user could publish a draft that was never scored, and the documented production worker ran Payload's dev schema push against the database on every run. This fixes those and the rest of what could be fixed without a product decision.Broken
fetch, which rejects it on Node 22 and 24. The crawler now uses undici's ownfetch.approvedandpublishedwere reachable from almost any status through the admin, REST or GraphQL, and an article could be created asverifiedwith a hand-set PASS. A newgatePublicationPathhook allows them only fromverified, from each other, or fromneeds_review/blockedwith a fresh justification.jobs:runnow disables the dev schema push; newjobs:webhooksandjobs:scheduledscripts do the same for the other two queues.ig-e2e.shread the wrong env file). Live research without an Ahrefs key now fails with a message instead of crawling the demo hostnames.downthat could not run, false override audit rows, stale evidence verdicts after reset/regenerate/send-back, topic removal during research, webhook errors storing the URL, re-seeding resetting the admin password, obsolete suggestions that never reopened, demo evidence that would expire in 2027, andpublishedAt/publishAthandling on every publish path.Scoring: number words match only as whole words,
the 1990sis a decade rather than 1,990 seconds, and2000matches2,000. Three accepted trade-offs are pinned in tests.Also: docs and env examples that contradicted the code, a missing
@payloadcms/graphqldeclaration, jsdom only for the component suites (integration run 98 s to 72 s), tests pinned to mock mode, E2E URLs that ignoredTEST_PORT, lint warnings in generated migrations, seven superseded migration snapshots, and a little dead code.Behaviour changes to know: a signed-in jump straight to
approved/publishedis refused;cms/.env.exampleships a blankPAYLOAD_SECRET;docker-compose.ymlbinds Postgres to127.0.0.1; articles and evidence-source rules cannot be deleted (archive /active: false).The open findings that need design work (server-action errors in production, stuck runs, mode resolution, rich text, slugs, cost rows on failed calls and more) follow in separate PRs.
Proof: reproduced the crawler failure on Node 22.23.2 and 24.21.0 and watched the new test pass on 22, 24 and 26; reproduced the PASS-on-create and delete holes and the broken migration
downagainst Postgres before fixing them; both typechecks, lint (0 warnings), pipeline tests 883/883, CMS integration 835/835 andnpm run build --workspace cmspass; a differential probe compares the matcher againstmainover 124 phrasings and 45 claim/evidence pairs. Playwright E2E was not run.Council review
Rounds: 7
Rounds 2 to 7 concerned the exact-value matcher only. A range change tried in rounds 2 to 4 was backed out; Grok's round-6 review did not complete.
Created with Claude Fable 5.2 (audit subagents also Claude Fable 5.2) in Claude Code, reviewed by Claude Opus 5.5, GPT-6.1 Sol and Grok 4.7.
🤖 Generated with Claude Code