feat(pruner): add default resource limits to controller and webhook - #4066
feat(pruner): add default resource limits to controller and webhook#4066infernus01 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4066 +/- ##
==========================================
- Coverage 26.95% 26.89% -0.06%
==========================================
Files 467 467
Lines 25170 25225 +55
==========================================
Hits 6785 6785
- Misses 17648 17703 +55
Partials 737 737
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b3d1d85 to
b0050f9
Compare
| return err | ||
| } | ||
|
|
||
| for i := range sts.Spec.Template.Spec.Containers { |
There was a problem hiding this comment.
can you please move this entire loop into a common function?
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
b0050f9 to
ff5b47f
Compare
Summary
Adds default resource requests and limits for
tekton-pruner-controllerandtekton-pruner-webhookdeployments in the operator.Changes
Modified
pkg/reconciler/kubernetes/tektonpruner/transform.goto include a newaddDefaultResourceLimits()transformer that injects defaultresource specifications:
tekton-pruner-controller
tekton-pruner-webhook
Rationale
Benchmark data: Testing showed the pruner controller uses 846-1126 MB heap memory when tracking 26k-38k resident PipelineRuns in its informer cache.
Override Mechanism
These defaults can be overridden via TektonConfig or TektonPruner CR:
The transformer runs before the options transformer, so user-specified values take precedence.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes