Repository navigation
release: cut v1.1.0 - #29
Merged
Merged
Conversation
v1.2.0 bounds a pxf.Decimal in Marshal, so check_decode can take the pb-render rows, and it carries the required-with-default check, so the copy in module.cc goes. cpp leaves Violation.name empty for that kind, so the bridge derives it from element and the Python API keeps its shape.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the build to protowire-cpp v1.2.0 and bumps the version to 1.1.0. Tag
v1.1.0once this merges. The tag publishes to PyPI, and a published version cannot be replaced.pxf.marshalnow refuses apxf.Decimalpast the bounds, where it used to hang (protowire#448).scripts/check_decode.pyhandlespb-render. Fixes check_decode: add pb-render once the protowire-cpp pin bounds a Decimal #28 together with the protowire PR that removespythonfrom those rows' skip lists.Violation.nameempty for this kind, so the bridge derives the name fromelementand the Python API does not change.Fixes #25
Evidence, built locally against C++ v1.2.0:
pytestgave 103 passed, 5 skipped. The corpus gate, withpythonunskipped in a scratch copy, ran 228 pairs across 6 ports (Python included) and all conformed. Run directly,decimal-huge-scaleanddecimal-huge-negative-scalewere refused immediately anddecimal-scale-4096was accepted. Go, C++ and TypeScript did not run in that gate, because no sibling harness was available there.