Register and delete custom containers - proto - #892
Lillian Hwang-Geddes (lvhg) wants to merge 24 commits into
Conversation
| string organization_id = 1; | ||
|
|
||
| // name format will be [user inputted name]:[first 8 characters of org id] | ||
| string name = 2; |
There was a problem hiding this comment.
Remind me why we need :[first 8 characters of org id]?
There was a problem hiding this comment.
It's to prevent possible collisions between custom containers and viam containers
There was a problem hiding this comment.
What kind of collision? How would such a collision come about
There was a problem hiding this comment.
The keys are name:version, so for example a collision would happen if a user had name=tf and version=2.16 since that matches one of the viam containers
|
|
||
| // Optional. Defaults to the image tag. Registered key is "name:version". | ||
| string version = 4; | ||
| string description = 5; // will serve as display name |
There was a problem hiding this comment.
I know we've already touched on this in at least one meeting, but it still seems odd to be to use description as a name. Would we run into a scenario where a user added a fairly long description, not realizing it was really a name, or will we always be masking the name of the field from them (so that they'll think they're providing the display name)? Or how will that be handled
There was a problem hiding this comment.
I see what you mean, John didn't want us to change it though since description is an existing field and changing it could cause issues. I am thinking we can add help text in the CLI to clarify things
…otics/api into register-delete-custom-containers
…t-custom-containers
Co-authored-by: Katie Peters <katiepeters@users.noreply.github.com>
…otics/api into APP-17611-list-custom-containers
…otics/api into register-delete-custom-containers
2 participants
https://viam.atlassian.net/browse/RSDK-14444