RSDK-14454: Add SetManualMode, GetManualMode and GetProperties to Arm API - #895
Merged
Nicolas Menard (npmenard) merged 1 commit intoSep 3, 2026
Merged
Conversation
Nicolas Menard (npmenard)
marked this pull request as ready for review
August 31, 2026 14:54
Nicolas Menard (npmenard)
requested review from
JohnN193,
Dan Gottlieb (dgottlieb) and
John Morales (john-morales)
August 31, 2026 15:01
This was referenced Aug 31, 2026
Member
|
Had a brief look at this, and nothing jumped out to me as a concern. Although I don't think my point of view here is particularly useful, so I'm going to remove myself as a reviewer. |
John Morales (john-morales)
removed their request for review
September 1, 2026 16:55
JohnN193
approved these changes
Sep 1, 2026
This was referenced Sep 2, 2026
Ale Paredes (ale7714)
added
the
ready-for-protos
Ale Paredes (ale7714)
removed
the
ready-for-protos
Nicolas Menard (npmenard)
deleted the
RSDK-14454-add-manual-mode-arm-api
branch
September 3, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three RPCs to the Arm service per the ManualMode Arm API scope:
SetManualMode(name, manual_mode, enabled_for)GetManualModeGetPropertiesIncludes regenerated Go and JS stubs.