Repository navigation
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comparing a module with no transform measurement against one with a measurement reports false growth from zero. A real zero also gets a
newratio label, and reopening a log can replace its final zero with an earlier nonzero size.Preserve unavailable measurements through the module comparison RPC, rows and totals. Keep those matched modules accessible in an Unavailable category. Preserve measured zero in detail badges and cached metrics, and rebuild old derived caches.
Follow-up to #615 and #601.
Evidence
pnpm lint,pnpm typecheckandpnpm buildpassed (7 build tasks).pnpm test --run: 410 passed, 2 skipped. Regressions cover RPC JSON transport, incomplete totals, zero baselines and cache restoration.Merge Danger
Door: two-way
Blast Radius: comparison
Module comparison values can now be null, with an unavailable status for matched modules. Shared comparison components handle these values. The cache version change rebuilds derived log caches on the next read; source logs stay intact.