Repository navigation
fix(prerender): build getPrerenderPaths() URLs from complete route params - #726
Merged
Merged
Conversation
…rams Prerender URLs for dynamic pages were built by plain string replacement of `:name`, which filled the wrong segment (`:id` inside `:idx`), ignored misspelled keys, and left values unencoded. Build them with interpolateRouteParams() instead. An invalid entry now fails the build with the server file and entry index, and prerendered files are written at the decoded path static hosts look up.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-prerender-path-params-void-cloud.voidzero-docs.workers.dev (commit c547ce1)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPrerenderPaths()entries were turned into URLs by plain string replacement, so some builds silently prerendered the wrong page:/u/:idx/:id{ id: '1', idx: '2' }/u/1x/:id/u/2/1/blog/:slug{ slg: 'hello' }/blog/:slug/blog/:slug{ slug: 'a b?c' }/blog/a b?c/blog/a%20b%3FcNow:
routeUrl(), with each value encoded./blog/a%20bis now written todist/client/blog/a b.html. Static hosts look for that file when serving the URL.Apps that relied on the old behavior (missing keys, or
/in a[slug]value) now get a build error instead of a wrong page.