fix(onboard): advance declared commands without obsolete stamps - #796
Merged
Merged
Conversation
Remove the retired Stop-hook stamp requirement from onboarding state. Focused onboarding/bootstrap regressions passed; full-suite failure is disclosed as unchanged compose-worker-prompt baseline timing evidence. Co-Authored-By: Codex <noreply@openai.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: 6 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe onboarding state gate no longer checks legacy verification or test stamp files. Tests now verify declared-command progression and use the ChangesOnboarding state transition
Priority: ➖ Normal Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The onboarding transition and regression fixtures match the intended removal of the obsolete stamp-file dependency, with no merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Collaborator
Author
|
This was written agentically; verify its assertions: Adversarial review receipt
🤖 Co-authored by Codex. |
Collaborator
Author
|
This was written agentically; verify its assertions: Review ledgerMachine-readable record of every review already performed on this PR. {
"version": 1,
"pr": 796,
"repo": "wrzonance/agent-kit",
"reviews": [
{
"kind": "adversarial",
"provider": "anthropic",
"model": "claude-opus-5",
"effort": "xhigh",
"mode": "cross-provider",
"attemptId": "55504c8f-3f48-467b-a204-3e981b1ae192",
"launcherSha256": "4d1fc623db1b387d5d6dc0792b56ea5fcc25bf1297a77b9aca4dab243902bd50",
"procedure": "one-shot diff review; no contract-blind or two-pass attestation",
"reviewerOverride": "",
"head_sha": "4463b3c67e4ff7d2029cbc8fb62fa74ab0b30a7f",
"covered_heads": [
"4463b3c67e4ff7d2029cbc8fb62fa74ab0b30a7f",
"f1ad65932840347b59f02d3710ff7949f4eb921f"
],
"diff_payload": "wrzonance/agent-kit:796:6dad119cc8e956914e10b73e0b100e9342aca40949dc3f87e0398ea77f4d9141",
"findings": [
{
"title": "Require verification evidence before onboarding state advances",
"severity": "P2",
"verdict": "declined",
"rationale": "Declining as contrary to the selected issue contract: issue787 explicitly offers dropping the retired stamp check as its simplest intended solution, with a declared command sufficient for advancement. This PR implements that option. Onboarding stage reports declaration/setup completion; it is not verification evidence and does not certify a passing command. Reintroducing a marker prerequisite would restore the dependency the issue intentionally removes. Relevant command success remains independently checked by agent-run and CI.",
"schemaVersion": 2,
"evidence": {
"finding": "Require verification evidence before onboarding state advances",
"decision": "rejected",
"rationale": "Declining as contrary to the selected issue contract: issue787 explicitly offers dropping the retired stamp check as its simplest intended solution, with a declared command sufficient for advancement. This PR implements that option. Onboarding stage reports declaration/setup completion; it is not verification evidence and does not certify a passing command. Reintroducing a marker prerequisite would restore the dependency the issue intentionally removes. Relevant command success remains independently checked by agent-run and CI."
}
}
],
"counts": {
"p1": 0,
"p2": 1
},
"reviewed_at": "2026-09-16T20:36:03Z",
"coverage": [
{
"sha": "f1ad65932840347b59f02d3710ff7949f4eb921f",
"reason": "merge-down:d60cdfd5c2cf98d88d35c3e8996544ef14349235",
"covered_at": "2026-09-17T22:43:32Z"
}
]
},
{
"kind": "bot",
"provider": "coderabbit",
"head_sha": "4463b3c67e4ff7d2029cbc8fb62fa74ab0b30a7f",
"state": "APPROVED",
"review_id": 5228054907,
"submitted_at": "2026-09-16T20:39:07Z",
"covered_heads": [
"f1ad65932840347b59f02d3710ff7949f4eb921f"
],
"coverage": [
{
"sha": "f1ad65932840347b59f02d3710ff7949f4eb921f",
"reason": "merge-down:d60cdfd5c2cf98d88d35c3e8996544ef14349235",
"covered_at": "2026-09-17T22:43:34Z"
}
]
}
]
}🤖 Co-authored by Codex. |
Collaborator
Author
|
@coderabbitai full review |
✅ Action performedFull review finished. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Carry the completed queue base into the onboarding stamp fix before final verification. Co-Authored-By: Codex <noreply@openai.com>
thewrz
marked this pull request as ready for review
September 17, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was written agentically; verify its assertions:
Why
Onboarding still required stamp files from the removed Stop hook, leaving repositories stuck at the declared stage even when their verification or test command was configured.
What
Decisions
This uses the issue’s simplest authorized option: a declared command is sufficient to advance the onboarding stage. The stage describes setup progress and does not certify that the command passed; command success remains a separate
agent-run.shand CI concern.The one adversarial review raised a P2 request to require verification evidence before advancing. It was declined because that would restore the retired marker dependency that #787 explicitly permits this change to remove. The published schema-2 terminal evidence records
decision: rejectedand the same rationale. The three-file PR patch is byte-identical against its original base and integratedmainatd60cdfd5c2cf98d88d35c3e8996544ef14349235, and none of those paths changed whilemainadvanced. The declined adjudication therefore remains unchanged; review-ledger lineage coverage is extended to the integrated head. Per the operator’s instruction, the existing CodeRabbit approval is retained without a repeat full-review request.Final integration metadata:
d60cdfd5c2cf98d88d35c3e8996544ef14349235f1ad65932840347b59f02d3710ff7949f4eb921fexisting adversarial and CodeRabbit entries extended over the clean integration; final gate rechecks bothTesting
20260916T182921Z-test.log; GREEN log20260916T183121Z-test.log.20260916T183339Z-test.log.20260916T184740Z-test.log.20260916T185138Z-test.log; this was not claimed as a full-suite pass.4463b3c67e4ff7d2029cbc8fb62fa74ab0b30a7fhad all four hosted checks green and CodeRabbit approval with no actionable findings.f1ad65932840347b59f02d3710ff7949f4eb921f: log20260917T223828Z-test.log, duration139 suites in 247 seconds, SHA-25667a30b24ca60c5939da362f4f9e09eea54079b5b15c9838ea89e920284aba16e.f1ad65932840347b59f02d3710ff7949f4eb921f: run 35283412531, all four checks green.mainintegration:existing adversarial and CodeRabbit entries extended over the clean integration; final gate rechecks both.Summary by CodeRabbit
Closes #787
🤖 Co-authored by Codex.