Skip to content

fix(onboard): advance declared commands without obsolete stamps #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewrz merged 2 commits into from
Sep 17, 2026
Merged

fix(onboard): advance declared commands without obsolete stamps #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4463b3c
fix(onboard): advance declared commands without obsolete stamps
Sep 16, 2026
f1ad659
chore(merge): integrate main into issue 787
Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agentkit/skills/.shared/scripts/onboard-state.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ elif [[ ! -r $board ]]; then
else
command_declared=no
grep -qE '^AGENT_CMD_[A-Z][A-Z0-9_]*=' "$config" 2> /dev/null && command_declared=yes
if [[ $command_declared == no || ( ! -r $repo_root/.agent/cache/stamp-verify && ! -r $repo_root/.agent/cache/stamp-test ) ]]; then
if [[ $command_declared == no ]]; then
state=declared; next=verify
else
tracked=no
Expand Down
2 changes: 1 addition & 1 deletion tests/test-bootstrap-repo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ assert_rc 0 'the generated board is ignored by git' -- \
# asserted by actually staging.
mkdir -p "$repo/.agent/cache" "$repo/.agent/logs"
printf 'account=someone home=/home/someone\n' > "$repo/.agent/env-contract.txt"
printf 'x\n' > "$repo/.agent/cache/stamp-verify"
printf 'discovered\n' > "$repo/.agent/cache/onboarding-stage"
printf 'x\n' > "$repo/.agent/logs/run.log"
git -C "$repo" add -A > /dev/null 2>&1
staged=$(git -C "$repo" diff --cached --name-only -- .agent | sort | tr '\n' ' ')
Expand Down
4 changes: 1 addition & 3 deletions tests/test-onboard-state.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ assert_contains "$out" 'stage=declared' 'config and board are declared'
assert_contains "$out" 'next=verify' 'declared reports verification as next'

printf 'AGENT_CMD_VERIFY=true\n' >> "$repo/.agent/config.env"
touch "$repo/.agent/cache/stamp-verify"
out=$("$state_sh" --repo-root "$repo" --report)
assert_contains "$out" 'stage=verified' 'a command plus verify evidence reaches verified'
assert_contains "$out" 'stage=verified' 'a declared command reaches verified without legacy stamp files'
assert_contains "$out" 'next=commit' 'verified reports commit as next'

# The blessed local model arms after verification once both declarations are
Expand Down Expand Up @@ -70,7 +69,6 @@ make_repo "$feature"
printf 'AGENT_REPO_SLUG=o/r\nAGENT_BASE_BRANCH=main\nAGENT_CMD_VERIFY=true\n' > "$feature/.agent/config.env"
printf '{"project":{}}\n' > "$feature/.agent/board.json"
printf '.agent/*\n!.agent/config.env\n!.agent/board.json\n' > "$feature/.gitignore"
touch "$feature/.agent/cache/stamp-verify"
git -C "$feature" add -- .agent/config.env .agent/board.json .gitignore
git -C "$feature" -c user.name=t -c user.email=t@example.invalid commit -qm trunk-base
git -C "$feature" checkout -qb feat/onboarding
Expand Down
Loading