Skip to content

RigShare 1.3.2: access hardening from the Manager review - #2

Merged
xiaodoudou merged 4 commits into
masterfrom
access-hardening
Oct 8, 2026
Merged

xiaodoudou merged 4 commits into
masterfrom
access-hardening

Conversation

@xiaodoudou

Copy link
Copy Markdown
Owner

Addresses the four suggestions on Comfy-Org/ComfyUI-Manager#3344:

  • Snapshot list/read check the workflow's folder role even with no live room
  • Websocket join checks access before creating or seeding a room (only editors open new rooms)
  • norm() refuses colon / trailing dot or space / 8.3 segments instead of dropping them (403 from routes)
  • Login redirect follows next only when same-origin

Tests added for the room-less access cases; norm tests updated to expect refusal.

@xiaodoudou
xiaodoudou merged commit 0b315f6 into master Oct 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant