Skip to content

zgx sidebar: labels that don't fit fade, and the foot's rows share one edge - #1231

Closed
gaelcado wants to merge 3 commits into
zeronsh:zeron/zgxfrom
gaelcado:gael/zgx-day-sidebar-label-fade
Closed

gaelcado wants to merge 3 commits into
zeronsh:zeron/zgxfrom
gaelcado:gael/zgx-day-sidebar-label-fade

Conversation

@gaelcado

@gaelcado gaelcado commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Carries the intent of #415: the sidebar's words never get cut and they line up. Rebuilt on the latest zeron/zgx. Wing's row building ("a chat's row is built again only as it changes"), his projects and his sidebar layout are unchanged.

  • Labels that don't fit fade at their end. zgx already fades chat titles, branches, project and device lines, group headers, pagers and archived rows (ds/fade_text). Section titles didn't: a section of yours with a long name, and the shared section title (Pinned, "Projects", the panel home's side chats), were cut mid-letter. They now fade. So do the title's drag card and the sidebar's connection notice, which used "…" before.
  • The foot's rows share one edge. The connection line ("Offline", "Reconnecting…") started 12 in, past where Star on GitHub's glyph, the filter and the empty list's words start (8 in). Its words also landed 5 px left of "Star on GitHub" after the offline dot, but on it after the reconnecting ring. The glyph now sits on the foot's edge in a slot as wide as the star, so its words start where the banner's do.
  • Zeron v2's copy of ds/sidebar.luau gets the same change (re-blessed).

Long section title (shell fixture, long_section), dark:

Foot, offline, before | after:

Foot, reconnecting, before | after:

Windows 11 VM, dark (cargo xwin build, fixture started offline with the long section): the title fades and "Offline" starts on "Star on GitHub":

No colour changed, so dark only.

Tests

  • label_fade_tests (Rust, shell fixture): every label in the sidebar that runs past its clip fades there, and one that fits doesn't; and under Star on GitHub, the connection line's words start where the banner's do (offline, unsaved, reconnecting). Both fail on the base (the cut title; the words at 34 vs 39) and pass here.
  • cargo test --release --no-fail-fast: no new failures vs a clean zeron/zgx (the same fit/editor/menu-bar/shortcut/examples/full-screen/leftovers failures fail there).
  • Luau zgx test .: 849 passed, 8 failed, all failing on the base too (Appshots ×2, settings_in_place ×3, link_menus, editor_menu, plugin_settings). zgx lint: 0 errors.
  • Long project, device, chat and branch names were also checked in a scratch copy of the fixture: all fade, and none is cut.

Platforms: Linux (fixture renders), Windows check (cargo xwin check) passes, Windows VM ✓ (shot above).

Follow-ups, not in this PR: none found that are the same kind. The level menu's drag card (Project/Device) and the "drop here" words are plain text, but their words are short, fixed and translated.

gaelcado and others added 3 commits November 5, 2026 21:16
"Offline" and "Reconnecting" stood 12 in, past Star on GitHub's glyph,
the filter and the empty list's words, which all start 8 in.

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
After the offline dot they stood 5 to the left of the banner's words; after
the reconnecting ring, on them. The glyph now sits in a slot as wide as the
star, as far from the words. A section's title being dragged fades at the
card's end, as on its row.
@gaelcado
gaelcado force-pushed the gael/zgx-day-sidebar-label-fade branch from 5b27906 to bc41750 Compare November 5, 2026 20:50
@gaelcado gaelcado changed the title zgx sidebar: a section's title that doesn't fit fades at its end zgx sidebar: labels that don't fit fade, and the foot's rows share one edge Nov 5, 2026
@gaelcado

gaelcado commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #1233 (the side panels, left and right, as one PR).

@gaelcado gaelcado closed this Nov 5, 2026
@gaelcado
gaelcado deleted the gael/zgx-day-sidebar-label-fade branch November 8, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant