Repository navigation
Conversation
"Offline" and "Reconnecting" stood 12 in, past Star on GitHub's glyph, the filter and the empty list's words, which all start 8 in. Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
After the offline dot they stood 5 to the left of the banner's words; after the reconnecting ring, on them. The glyph now sits in a slot as wide as the star, as far from the words. A section's title being dragged fades at the card's end, as on its row.
gaelcado
force-pushed
the
gael/zgx-day-sidebar-label-fade
branch
from
November 5, 2026 20:50
5b27906 to
bc41750
Compare
Contributor
Author
|
Folded into #1233 (the side panels, left and right, as one PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the intent of #415: the sidebar's words never get cut and they line up. Rebuilt on the latest
zeron/zgx. Wing's row building ("a chat's row is built again only as it changes"), his projects and his sidebar layout are unchanged.ds/fade_text). Section titles didn't: a section of yours with a long name, and the shared section title (Pinned, "Projects", the panel home's side chats), were cut mid-letter. They now fade. So do the title's drag card and the sidebar's connection notice, which used "…" before.ds/sidebar.luaugets the same change (re-blessed).Long section title (shell fixture,

long_section), dark:Foot, offline, before | after:

Foot, reconnecting, before | after:

Windows 11 VM, dark (cargo xwin build, fixture started offline with the long section): the title fades and "Offline" starts on "Star on GitHub":

No colour changed, so dark only.
Tests
label_fade_tests(Rust, shell fixture): every label in the sidebar that runs past its clip fades there, and one that fits doesn't; and under Star on GitHub, the connection line's words start where the banner's do (offline, unsaved, reconnecting). Both fail on the base (the cut title; the words at 34 vs 39) and pass here.cargo test --release --no-fail-fast: no new failures vs a cleanzeron/zgx(the same fit/editor/menu-bar/shortcut/examples/full-screen/leftovers failures fail there).zgx test .: 849 passed, 8 failed, all failing on the base too (Appshots ×2, settings_in_place ×3, link_menus, editor_menu, plugin_settings).zgx lint: 0 errors.Platforms: Linux (fixture renders), Windows check (
cargo xwin check) passes, Windows VM ✓ (shot above).Follow-ups, not in this PR: none found that are the same kind. The level menu's drag card (
Project/Device) and the "drop here" words are plain text, but their words are short, fixed and translated.