Repository navigation
章节层 start_seg 乱序排序归一化 + chapters_error 落盘(含未触碰层回填) - #225
Merged
Merged
Conversation
Agent-Executor: glm-pi Agent-Model: glm-5.3-flash Agent-Effort: high Dispatch-Id: dlg-20261010-101342-e71d15 Task-Id: VideoTranscriptAPI-20261015-01
Agent-Executor: glm-pi Agent-Model: glm-5.3-flash Agent-Effort: high Dispatch-Id: dlg-20261010-101342-e71d15 Task-Id: VideoTranscriptAPI-20261015-01
Agent-Executor: glm-pi Agent-Model: glm-5.3-flash Agent-Effort: high Dispatch-Id: dlg-20261010-101342-e71d15 Task-Id: VideoTranscriptAPI-20261015-01
Agent-Executor: glm-pi Agent-Model: glm-5.3-flash Agent-Effort: high Dispatch-Id: dlg-20261010-112540-21485d Task-Id: VideoTranscriptAPI-20261015-02
Agent-Executor: codex Agent-Model: gpt-6-luna Agent-Effort: xhigh Dispatch-Id: dlg-20261010-113820-28d9e9 Task-Id: VideoTranscriptAPI-20261015-03
Required Gate v2 — 状态面板当前状态:pass · 可合并 当前裁决: PR 累计主审轮(影子): Gate 历史(v1;来源为持久化
|
| Run | Attempt | Head | 状态 | PR 累计主审轮(影子) | 收件人动作 |
|---|---|---|---|---|---|
| 38049989670 | 1 | a449b6e |
fail |
— |
要修代码 |
| 38051657840 | 1 | 0e957bb |
pass |
2/5 · collecting |
可合并 |
历史行按 run_id + run_attempt 去重并只增不删;删除本评论后可由 gate_terminal 制品重建。
chapters_error 原以中段插入方式进入签名(介于 chapters_status 与 notes_status 之间),违反本仓「新参数只许尾部追加」的演进惯例:未来若有 位置传参调用方,该参数会错位绑定 notes_status / artifact_provenance。 本次只把该参数移到 artifact_provenance 之后,并把 docstring 中对应的 说明段同步移到 artifact_provenance 说明之后(文字不变)。函数体一行未动, 合并语义(非 None 才写入、generated 强制清空)完全不变。 现有 57 处调用点经 AST 核查:0 处位置传参到达该槽位,2 处 **dict 展开 按名字绑定,故为零行为变更。 Agent-Executor: minimax-pi Agent-Model: MiniMax-M3.1-Flash-Preview Agent-Effort: high Dispatch-Id: dlg-20261010-121515-9fb3a5 Task-Id: VideoTranscriptAPI-20261015-04
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
生产事故:BV1fcHD6cEw3(2026-10-10)章节层两次因「start_seg 序列非严格递增」语义校验失败整体判 FAILED,
llm_chapters.json未落盘,视图页无章节目录。主脑生产取证 + 双顾问咨询(claude-opus / codex,任务 vta-chapters-order-rootfix-20261015,报告归档于 agent-config consult 记录)后拍板根治方向。改动
A. 排序归一化(
llm/processors/chapters_processor.py)_validate_and_normalize_start_segs:去重后非严格递增从整体判 FAILED 改为按start_seg排序归一化;排序确实改变顺序时打 warning(含 moved 错位数 + LIS 长度,生产样本实测 moved 6/17、LIS 14/17)test_chapters_processor.py原断言同步改写)。依据:数组排列顺序是start_seg取值集合的冗余表示;生产 dialogs 逐章核验确认乱序样本各章 gist 与排序后区间全部吻合(非主题回溯),原校验把可救数据判死_derive_end_segs之前(数组顺序隐含区间划分);(title, gist, start_seg)配对不变;已升序输入零行为变化/regenerate_chapters端点(重提交同 URL 已可单层补跑)B. chapters_error 落盘(
cache_manager.py+llm_ops.py)save_llm_status新增chapters_error:None=不更新;chapters_status=="generated"时强制 pop 旧 error(不变式锁单点,防 caller 误传)_save_llm_results提取并按既有final_*回填模式传入:effective_chapters_status is not None用本轮值,未触碰层(resummarize / generate_notes)回填old_llm_status旧值(write-ahead 撤销后磁盘已空,不回填会静默丢历史失败诊断)验证
make test默认 TMP exit=0 零失败(主脑实测)30466452..819b6f84):结论继续,I1–I10 全过,failure-visibility: p2-only;唯一 P2(两个统计 helper 单调用方)判定接受不修(卡面 I4 强制 warning 统计,helper 是其最小实现,测试锁精确数值),verdict 见docs/sessions/chapters-sort-261015/reviews/VideoTranscriptAPI-20261015-01-verdict.md819b6f84补齐并加契约测试提交
9cfed705章节层 start_seg 乱序改为排序归一化4d0dbe70chapters 失败原因落盘 llm_status.jsond5445149CHANGELOG 条目819b6f84chapters_error 层未触碰回填(review finding 修复)a449b6e7独立 review verdict 归档后续
已知取舍与跟进项(验收 consult 裁决)
Gate primary finding 处置对照表(run 38049989670)
compatibility-positional-parameter-shift(chapters_error 中段插参,假想位置调用方错位绑定 notes_status/artifact_provenance)**status_updates关键字解包);按仓内「内部签名只许尾部追加」演进惯例(llm/core/config.py 同款纪律)仍属应守规约chapters_error移至签名尾部(append-only),零行为变更(全关键字传参),commit 见 PR head