Skip to content

补充分享页 OG 大图标签的浏览器回归 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zj1123581321 merged 1 commit into from
Oct 16, 2026
Merged

补充分享页 OG 大图标签的浏览器回归 #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions e2e/tests/pages.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,39 @@ test('cleaned view smoke: cleanup state and recovery guidance are visible', asyn
await expect(page.getByRole('heading', { name: /内容已清理/ })).toBeVisible();
await expect(page.getByText(/重新获取转录/)).toBeVisible();
});

test('share view with card emits twitter large image and og tags', async ({ page }) => {
const token = 'browser-fixture-view-og';
const headline = 'Fixture "headline" & alt';
await page.goto(`/view/${token}`);
await expect(page.locator('meta[name="twitter:card"]')).toHaveAttribute(
'content',
'summary_large_image',
);
await expect(page.locator('meta[property="og:image"]')).toHaveAttribute(
'content',
`${baseURL}/og/${token}.png?v=1`,
);
await expect(page.locator('meta[property="og:image:width"]')).toHaveAttribute(
'content',
'1200',
);
await expect(page.locator('meta[property="og:image:height"]')).toHaveAttribute(
'content',
'630',
);
await expect(page.locator('meta[name="twitter:image:alt"]')).toHaveAttribute(
'content',
headline,
);
await expect(page.locator('meta[property="og:description"]')).toHaveAttribute(
'content',
'First fixture point',
);
});

test('share view without card omits twitter card and og image tags', async ({ page }) => {
await page.goto('/view/browser-fixture-view');
await expect(page.locator('meta[name="twitter:card"]')).toHaveCount(0);
await expect(page.locator('meta[property="og:image"]')).toHaveCount(0);
});
9 changes: 9 additions & 0 deletions tests/browser_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
VIEWS_SOURCE = ROOT / "src" / "video_transcript_api" / "api" / "routes" / "views.py"
FIXTURE_TOKEN = "browser-fixture-token"
VIEW_TOKEN = "browser-fixture-view"
VIEW_TOKEN_WITH_CARD = "browser-fixture-view-og"
UPLOAD_VIEW_TOKEN = "upload_browser_fixture_view_1"
UPLOAD_ID = "browser-fixture-upload-1"

Expand Down Expand Up @@ -515,6 +516,14 @@ def serve_view(self, status: str, view_token: str = VIEW_TOKEN) -> None:
"error_message": "夹具失败状态",
"message": "夹具失败状态",
}
if view_token == VIEW_TOKEN_WITH_CARD:
port = self.server.server_address[1]
context["share_card"] = {
"headline": 'Fixture "headline" & alt',
"points": ["First fixture point", "Second fixture point"],
"generated_at": "2026-10-16T12:00:00+08:00",
}
context["og_image_url"] = f"http://127.0.0.1:{port}/og/{view_token}.png?v=1"
html = TEMPLATES.get_template(template_name).render(**context)
self.send_bytes(200, html.encode("utf-8"), "text/html; charset=utf-8")

Expand Down
Loading