test: add human gold review gate and trusted scorer - #50
Merged
Conversation
Guard reading preset sampling against short books so a one-page Komga comic cannot construct the invalid range 2..<1. Reuse the safe policy in both startup paths and cover empty, short, and long page counts with regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
candidate,expectedPageState: unknown,review: null, and manifest statuspendingCorrected candidate
The current candidate reconstructs these three visible text blocks:
「有名人」の基準は、「ウィキペディアに記事があるか」です。ウィキペディアにのってたら有名人です。ウィキペディアにのってないのに有名人のようにふるまうのは自惚れです。The three left-top columns share one physical speech-balloon ID. The right and lower-left rectangular narration boxes deliberately have no
bubbleID. Decorative face/newspaper marks are excluded.Human-review boundary
This PR still deliberately does not promote the Shirohage page to
humanVerifiedand does not claim OCR accuracy from a model-created/corrected candidate. The user-provided screenshot was used as review evidence to fix obvious false positives, fragmentation and missing columns, but final character-by-character/rectangle confirmation against the pinned source image is still required before a review receipt can be recorded.Pinned Shirohage source image SHA-1:
8c828fc750e946ce94038a00782cbe115537c15eReview aid:
docs/shirohage-gold-review.mddocs/shirohage-gold-review-overlay.pngRegression coverage
humanVerifiedwithout a review receipt is rejectedScope note
An unrelated local fix for a one-page reader startup crash briefly landed on this branch. It has been removed from this PR's net diff and preserved separately in PR #51.
Next handoff
After final human confirmation of the corrected 10-region candidate, a small follow-up can record the receipt, resolve page state, promote the fixture to
ready, and compute the first reportable real-page benchmark numbers.