Skip to content

fix: prevent single-page reader startup crash - #51

Merged
zyk1172 merged 1 commit into
mainfrom
codex/reader-single-page-startup-fix
Sep 12, 2026
Merged

fix: prevent single-page reader startup crash#51
zyk1172 merged 1 commit into
mainfrom
codex/reader-single-page-startup-fix

Conversation

@zyk1172

@zyk1172 zyk1172 commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • prevent one-page/short books from constructing an invalid 2..<1 reading-preset sample range
  • centralize sample-page selection in ReadingPresetSamplePagePolicy
  • reuse the safe policy in both reader startup detection paths
  • add regression coverage for 0, 1, 2, 3, 5 and 8 page books

Scope

This change was originally committed locally on the #50 branch, but it is unrelated to the translation Gold review work, so it has been split into this standalone PR without losing the original fix.

@zyk1172
zyk1172 merged commit e13a646 into main Sep 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant