Repository navigation
Fix saved evidence checks and validate real-drive workflows - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check could report preserved Finder metadata as missing, and two selected subfolders on one Mac disk could miss physical-drive resolution. This fixes both, preserves destination progress through MHL/report work, bounds diagnostic export reads, and corrects PDF pagination and preview counts. It also removes quadratic result lookup and a repeated queue-view update warning during many-file transfers.
Two small additions stay tucked away: reviewed transfer-preferences import/export in Settings, and a Mac Advanced hint for backups reporting a USB 2 connection. Verification defaults, source protection and overwrite rules remain unchanged.
Most of the diff is regression coverage and reproducible local harnesses. Completed checks include:
Full revisions, exact counts, corrected harness attempts and limits are in the overnight validation record. A local signed universal diagnostic archive is retained; it was not published. Native final import actions, progress/status-menu walkthroughs and physical mobile-provider/background behavior remain unvalidated. The paired application benchmark stopped at fixture setup before any transfer, so it supplies no comparative performance result. GitHub Actions credits are exhausted; these gates ran locally.
Issues #10 and #23 stay open. The tests do not establish either reporter’s exact failure mechanism. No merge or release is included. Filename safety is separately reviewed in #63, followed by the reviewed-exclusion queue policy in #64; updater metadata is independent in #62.