Repository navigation
Handle ambiguous filenames without crashing transfers - #63
Merged
Merged
Conversation
This was referenced Oct 20, 2026
mikecerisano
marked this pull request as ready for review
October 20, 2026 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two filenames can be distinct on disk but compare equal in Swift. Disposable HFS+ images reproduced two crashes with
K.movandK.mov: one before copying, another while checking the destination after verification.The engine now refuses an ambiguous captured source manifest before copying. Ambiguous destination metadata produces failed results, with no new MHL history or safe verdict. Sources, existing files and prior histories remain intact. No filename rewriting or verification-default change.
Stacked on #61 so this review contains only the filename fix, regressions and its validation record.
Local validation:
See
docs/validation/UNICODE_SOURCE_PREFLIGHT_20261020.mdfor exact counts, 78 separate raw driver probes and coverage limits. Final signed-UI and physical-mobile walkthroughs remain separate. These reproductions do not establish the cause of #10 or #23. GitHub Actions credits are exhausted; local receipts are the gate. No merge or release is included.