Skip to content

feat: add scoped Spec Studio audits and confirmed remediation - #260

Open
Coding-Dev-Tools wants to merge 20 commits into
mainfrom
codex/spec-crawl-readiness-20261010
Open

Coding-Dev-Tools wants to merge 20 commits into
mainfrom
codex/spec-crawl-readiness-20261010

Conversation

@Coding-Dev-Tools

@Coding-Dev-Tools Coding-Dev-Tools commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Description

Spec Studio adds a deterministic v2 specification crawler and scoped memory-cluster audit to the dashboard, REST API, Classic MCP, and Smart MCP discovery. It reports ambiguity, injection patterns, claim support, and advisory memory remediation while leaving analysis read-only.

Parameter conflicts require positively matching nonempty subject keys and compatible claim kinds. The index groups records by subject before comparison so unrelated parameter values cannot create or hide conflicts. Supersession suggestions use distinct finite valid_from dates; ingestion order cannot select a historical backfill as the keeper. Missing, invalid, or equal effective dates and unproven divergences produce clarification without keeper/retirement targets. The UI displays those instructions and effective dates safely. Failed evidence lookups remain unchecked, do not count as unsupported claims, and do not penalize the score; successful abstentions remain untraced.

Scope and owner checks restrict memory analysis to approved live records. HTTP accepts direct text or approved procedural-memory inputs; local-operator MCP file reads stay within approved roots. Clarifications remain pending for review. Supersession requires explicit confirmation and validates both records before atomically linking and closing validity. The UI rejects stale scoped responses, renders untrusted text safely, reports actual failures, and supports accessible clarification dialogs.

The full browser gate exposed a deferred-fit camera race in the every-node renderer. Hidden zero-size measurements now preserve the last usable viewport. Worker preview, ready, and final-layout fitting respect manual keyboard, wheel, drag, pinch, and focus navigation; explicit Fit remains available. Controlled real-worker browser tests preserve exact projected camera equality across hiding and replay, including tiny drags and ordinary automatic fitting.

Evaluation enforces section counts and score bounds in full-stack and NumPy-only CI. MCP contracts, skill hashes, guides, and public charts are synchronized with immutable offline evidence. README benchmark links are pinned to the source/evidence commit for PyPI rendering. Historical artifacts and unrelated primary-checkout work remain preserved.

Type

  • Bug fix
  • New feature
  • Documentation
  • CI/CD

Verification

  • 136 focused Python checks passed, followed by the affected 30 multi-node and 73 evidence/documentation/release checks after assertion and URL corrections.
  • All eight Spec Studio Chromium checks passed, including safe rendering and no supersession for ambiguous keeper dates.
  • 290 graph asset checks and the existing 24-test graph lifecycle run passed; six targeted checks passed after the final tiny-drag and explicit-fit corrections.
  • ruff check ., Pyright 1.1.414, commercial/CSP drift checks, MCP contract export, and the Spec Crawl evaluation passed.

Current head: d87bb31d9c09265904b2c4477dda9831c7ecf5db. Fresh full CI is running at https://github.com/Coding-Dev-Tools/engraphis/actions/runs/38070240255; results from the previous head do not qualify this changed head. The three review findings are implemented and their original threads are outdated; formal thread resolution remains subject to the repository approval protocol.

@Coding-Dev-Tools
Coding-Dev-Tools marked this pull request as ready for review October 10, 2026 08:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T13:27:29.704509Z b34cf20 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a7e1dd391

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/core/spec_crawl.py Outdated
Comment thread engraphis/core/spec_crawl.py Outdated
Comment thread engraphis/service.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99189b0990

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/service.py Outdated
Comment thread engraphis/service.py Outdated
Comment thread engraphis/service.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d87bb31d9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/core/spec_crawl.py
Comment thread engraphis/core/spec_crawl.py Outdated
Comment thread engraphis/mcp_server.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ffa3cc1be1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/service.py
Comment thread engraphis/service.py
Comment thread engraphis/core/spec_crawl.py
Comment thread engraphis/service.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d2f945319

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/service.py Outdated
Comment thread engraphis/service.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 819d80f10a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/core/spec_crawl.py
Comment thread engraphis/dashboard_assets/spec-crawl.js Outdated
Comment thread scripts/spec_crawl.py Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant