๐ [๋ณด์] CLI ๋ฌด์ ํ ํ์ผ ์ฝ๊ธฐ ์ทจ์ฝ์ ์์ - #811
๐ [๋ณด์] CLI ๋ฌด์ ํ ํ์ผ ์ฝ๊ธฐ ์ทจ์ฝ์ ์์ #811seonghobae wants to merge 99 commits into
Conversation
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
๐ WalkthroughWalkthroughCLI์ stdin, ์ธ๋ผ์ธ ์์
, ์์
ํ์ผ ์
๋ ฅ์ UTF-8 ๋ฐ์ดํธ ๊ธฐ์ค 10MB ์ ํ์ ์ถ๊ฐํ์ต๋๋ค. ์๋ชป๋ ์ธ์์ ๊ถํ ์๋ ์์
ํ์ผ์ ๊ฑฐ๋ถํฉ๋๋ค. ์ง์ ์ ์ธ ChangesCLI ์ ๋ ฅ ๋ฐ ์์ ํ์ผ ๊ฒ์ฆ
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ๐ก Moderate ยท up to The CLI still misclassifies CONOUT$: as an alternate stream before applying console-handle validation, causing the required regression test to fail at the current head. Merge should wait for the classification-order fix and passing regression; documentation and test-coverage follow-up also remain. Sequence Diagram(s)sequenceDiagram
participant InputSource
participant cli_main
participant JobFile
participant JSONParser
InputSource->>cli_main: stdin, inline --job, or job file argument
cli_main->>cli_main: validate explicit arguments
cli_main->>JobFile: bounded regular-file read with identity checks
JobFile-->>cli_main: bounded UTF-8 bytes
cli_main->>JSONParser: decode and parse JSON
JSONParser-->>cli_main: parsed job or structured error
Possibly related issues
๐ฅ Pre-merge checks | โ 5โ Passed checks (5 passed)
โจ Finishing Touches ๐ก 1๐ ๏ธ Fix failing CI checks ๐ก
๐ Generate docstrings
๐งช Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headec183bf199e0e82b6c29d6c2a01b795e31746e97. -
Head SHA:
ec183bf199e0e82b6c29d6c2a01b795e31746e97 -
Workflow run: 31338219474
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test (2 files)"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test (2 files)"]
R2 --> V2["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (5 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (5 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: cli-job-file-authority.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: cli-job-file-authority.md"]
R2 --> V2["docs review"]
Evidence --> S3["Test (7 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (7 files)"]
R3 --> V3["targeted test run"]
|
|
@opencode-agent Please rerun the coverage/review contract on exact current head |
8bab6d6 to
071ba74
Compare
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head9c4a8410f6c118ec74c81d0794fe78027bb85392. -
Head SHA:
9c4a8410f6c118ec74c81d0794fe78027bb85392 -
Workflow run: 32037920292
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: cli-job-file-authority.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: cli-job-file-authority.md"]
R2 --> V2["docs review"]
Evidence --> S3["Test (6 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (6 files)"]
R3 --> V3["targeted test run"]
0d56f39 to
9c4a841
Compare
CONIN$/CONOUT$ follow the 2021-12-30 console-handles contract, not naming-a-file reserved names. CLOCK$ stays a fail-closed legacy device. Drive-relative jobs still fail before lstat or open.
Keep AGENTS, ARCHITECTURE, CLAUDE, CHANGELOG, and doctoring aligned with the lexical authority classes on --job paths.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current heade0115bed68409c009f1966a14087c87c8f2f0d81. -
Head SHA:
e0115bed68409c009f1966a14087c87c8f2f0d81 -
Workflow run: 32113960711
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (5 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (5 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: cli-job-file-authority.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: cli-job-file-authority.md"]
R2 --> V2["docs review"]
Evidence --> S3["Test (7 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (7 files)"]
R3 --> V3["targeted test run"]
|
Queued @opencode-agent for PR #811 at head |
|
Queued @opencode-agent for PR #811 at head |
|
Queued @opencode-agent ; Already queued @cwl-noema-review on this exact request for PR #811 at head |
85c717a to
e0115be
Compare
|
Queued @opencode-agent ; Already queued @cwl-noema-review on this exact request for PR #811 at head |
3 participants
Security and availability boundary
The CLI treats each explicit input source as a bounded, fail-closed authority boundary. This canonical branch hardens stdin, inline
--job, and file-backed--jobhandling without changing dependency, database, model, connector, or review-credential state.Protected base:
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.Exact current head:
e0115bed68409c009f1966a14087c87c8f2f0d81.Current implementation
MAX_JSON_FILE_SIZE + 1raw bytes before UTF-8 decode / JSON parsing.Job input must be valid UTF-8.--statusand explicit--jobbefore touching stdin; malformed explicit invocations fail immediately.CONIN$/CONOUT$console handles, fail-closed legacyCLOCK$, and relevant Win32 leading/trailing-space normalization ambiguity before filesystem authority is acquired.os.lstat/os.open./to\\only for UNC/device-namespace lexical classification, so mixed-separator forms such as/\\server\\share,\\/server\\share,/\\.\\pipe\\..., and/\\?\\UNC\\...cannot bypass pre-open rejection.CONOUT$:retain the correct fail-closed authority class.O_RDONLYplusO_CLOEXEC,O_NOFOLLOW, andO_NONBLOCKwhere available, then revalidates the obtained descriptor as the same regular-file inode before bounded reads.Regression-first repairs
Blocking-open substitution race
RED
610c75637e773d5245c6ec16b8b7a046ac8ff98faddedtest_job_file_open_requests_nonblocking_mode_when_supported; exact RED CI run31936034882, job95137981019, failed at the intended flag contract. GREEN308970565ebbefe88b823114d4a8b560bc2f4caeaddsgetattr(os, "O_NONBLOCK", 0); doctoring/CHANGELOG scope that guarantee to hosts exposing the flag.Win32 lexical authority
The regression set requires drive-relative (
C:job.json), alternate-stream, reserved-device,CONIN$/CONOUT$:,CLOCK$, leading-space normalized aliases, and mixed-separator UNC/device forms to fail before filesystem lookup. The current console-handle regression also preserves the documented distinction betweenCONIN$/CONOUT$, naming-a-file reserved filenames, and fail-closed legacyCLOCK$while keeping every class outside filesystem authority.Current-head convergence
9c4a8410f6c118ec74c81d0794fe78027bb85392already preserved the rejection invariant. Two direct successor commits refine the current contract without weakening it: the production classifier now returns distinct console-handle/reserved/legacy authority classes with device checks ordered before ADS classification, ande0115bed68409c009f1966a14087c87c8f2f0d81aligns AGENTS, ARCHITECTURE, CLAUDE, CHANGELOG, and doctoring with that code-current contract. Current source still rejects mixed UNC/device forms beforeos.lstat/os.open.All currently visible inline review threads are resolved. Predecessor-head reviews remain predecessor evidence; the exact-current-head OpenCode review is still
CHANGES_REQUESTEDsolely because required centralcoverage-evidenceis non-passing, not because of a BandScope product-code finding.Exact-current-head repository evidence
On exact head
e0115bed68409c009f1966a14087c87c8f2f0d81, repositoryci,release,build-baseline,sbom,SAST Semgrep,bandit, andsecret-scan-gateare terminal-success.security-auditand aggregateSecurity Scanremain terminal-failure on the protected-base JavaScript findings already owned by canonical #783. This branch has no JavaScript dependency/root-lock or vulnerability-suppression delta, so those findings are neither copied nor suppressed here and are not counted as success.Dependency / merge gate
develop.ContextualWisdomLab/.github#1124atd82718d1011bbcf8acc842159d91972daef4f7d1, still open Draft. Do not add a BandScope-local workaround or redispatch unchanged review work before that owner reaches protected centralmain.Keep unmerged until the unchanged then-current head has every applicable repository/central CI, cross-platform build, exact owned statement+branch coverage, docstring, SAST/security/SBOM/supply-chain/package/release gate terminal-success; zero valid unresolved findings; a qualifying independent non-author last-push approval; and ordinary branch-protection acceptance. Never bypass protection or transfer predecessor evidence.
Queued, in-progress, skipped-required, failed, predecessor-head, protected-base, model-only, self/author, or administrative-bypass evidence is not success.