Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Sent back by desktop merger mB. The branch is 556 commits behind main and conflicts in commander/order.py, external_transcript.py, todos.py, tools.py, turn_digests.py and two tests. Main moved the commander board into todos.py (P707), so CommanderView, CommanderOrder and CardDetail have to read main's CheckedProblemOrder and board_cells rather than re-deriving orders. Merge current main once, delete anything here that main's board already owns, then rerun tests and ratchets. Due 00:45. |
|
Not merged: conflicts with main in commander/order.py and external_transcript.py. Rebase. |
|
Dropped from batch cl-49: this is a real conflict, not a trivial one. Rebase onto current main (d543640) before it can land. Main has since replaced the progress model this PR builds on:
Keep these parts and port them onto main's owners:
|
|
Closed: replaced by #2179 (P769), which ports this board onto main's progress owners. Stable-base cleanup 2026-10-20. |
Commander board and derived cadence (P243; duplicate P245)
Paired UI: OpenHCSDev/toad#1080 at
83393d08a. Core implementation checkpoint:ca9c4f881./commander <commander-thread>shows open orders, deadlines, delivery state, overdue-first cards, expanded original turns/commits, and alarms. The collapsed cards now display next-commit cadence and deadline margin.UnitCard.momentum(src/agent_comms/ui_model/commander.py:105) derivesCommitMomentum(src/agent_comms/todos.py:274) from order times and bounded actual branch commits. Unknown cadence is not a zero timestamp. No momentum is stored and no timer or separate scorer was added.Commit cadence does not establish remaining work: the UI explicitly labels completion unknown. Full parity row 27's prediction/outcome comparison remains unverified; pi-plan-claims owns its binding in #1992. No parallel parity registry or plan_phases.py edit was added here.
Ownership repairs
Checks
timeout 300 ... -X faulthandlerenforced; pytest-timeout plugin warning only.b793c7325; no subsequent merge-main or rebase was done. Stable full reports: src 1 (+465 SourceLines only), tools 1 (+205 SourceLines only), introduced findings empty. Atca9c4f881, completed full reports are src 1 (+474 SourceLines only) and tools 1 (+205 SourceLines only), with introduced findings empty. No budget, baseline or suppression was changed. Commander's message 3617 explicitly rules SourceLines-only findings non-blocking.Actual behavior proof
Normal Toad under plain st on isolated Xvfb, real observation child, copied real saved sessions, real tool-created scratch-bus orders, and an actual retained refusal. Opened via normal prompt, clicked a real card, expanded original turns, recorded delivery through Core's tool, observed the same open page update and clear the stall, then returned to the same conversation. No provider was launched; originals and uncertain inputs were preserved.
Latest inspected captures and successful continuous-journey receipt:
/home/ts/.cache/agent-scratch/pi-cn-phase6/physical-failure-owner/level-0.txt/pnglevel-1.txt/pnglive-delivery.txt/pngsources.txt,result.txtVisible text includes:
Integration status
Not merged or installed. GitHub reports a conflict with current main; per the no-merge-main rule, published history is preserved and no rebase is attempted without the commander's explicit conflict instruction. The native immutable order identity below is generated by Core's existing order owner, not handwritten. The mandated
order pr P243create command failed because its derivedpi-cn-phase6--P243checkout does not exist; the assigned checkout ispi-cn-phase6--P1and this PR already exists. Its existing review thread is updated in place using Core-generated metadata, not replaced.Assumed:
Agent-Comms-Order: 69f8a4afa37a