Skip to content

Phase 6: commander board with expandable unit cards - #1080

Closed
trissim wants to merge 8 commits into
mainfrom
feat/cn-phase6-page
Closed

trissim wants to merge 8 commits into
mainfrom
feat/cn-phase6-page

Conversation

@trissim

@trissim trissim commented Oct 19, 2026 •

Copy link
Copy Markdown

Commander board with Core-derived cadence

Pair with OpenHCSDev/agent-comms#1937 (implementation ca9c4f881, evidence update 5bc9d1500). Toad source head: 83393d08a.

  • /commander <commander-thread> is discovered through the existing command declarations.
  • Core owns order meaning, deadlines, progress, alarms and momentum. Toad renders typed observed cards. No store readers, copied schemas, refusal log, scorer or new timer.
  • Collapsed cards keep Core's next-commit cadence/deadline margin visible. Expanded cards load canonical order text, actual commit and original turns lazily. Completion remains explicitly unknown.
  • Conversation callbacks derive GoalBar capability from actual composition instead of assuming an optional cached child. FeedTarget -> commander open/click no longer exposes a goal_bar traceback.
  • py.typed publishes existing inline declarations so the paired Core application tool checks against the real Toad types rather than copied stubs.

Behavior proof

Normal Toad in plain st on isolated Xvfb, real observation process, real tool-created scratch-bus orders, copied real saved histories, and an actual refused send. Opened through the prompt, clicked one card, expanded original turns, observed delivery and stall clearing without reopening, and returned to the identical conversation. Captures inspected with no traceback pane. No provider was started and originals/uncertain inputs were preserved.

Retained proof: /home/ts/.cache/agent-scratch/pi-cn-phase6/physical-failure-owner/
level-0.txt/png, level-1.txt/png, live-delivery.txt/png, sources.txt, result.txt.

Checks and integration

  • Core stable batch 142 passed; current failure-owner checks 10 passed.
  • Full Core source/tools ratchets at implementation head: 1/1, solely SourceLines (+474/+205), introduced findings empty. Message 3617 explicitly rules that sole measure non-blocking. No budget/checker/baseline change.
  • Paired-tool type checking uses this actual source and existing stack dependencies. Diff check passes; no standalone Toad suite or installation is claimed.
  • Full prediction/outcome parity is not claimed. These are source-paired application results, not normal-launcher installation.
  • Core currently conflicts with newer main. Published history is preserved pending the commander's explicit conflict/rebase instruction; no merge-main commit was added after that rule.

Assumed: cadence forecasts the next commit, not completion; integration and installation remain with the merger/installer.

@trissim
trissim marked this pull request as ready for review October 19, 2026 23:59
Copilot AI balanced review requested due to automatic review settings October 19, 2026 23:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Author

Superseded by #1095 (P769), which renders the same commander board from Core observations; this one conflicts with main.

@trissim trissim closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants