Repository navigation
Let open viewers survive installs by tracking selected bus identity - #2860
Merged
Merged
Conversation
…times # Conflicts: # tests/test_installer_route_lifetime.py
trissim
marked this pull request as ready for review
October 23, 2026 20:33
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at c59ba24, every finding: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core #2860 and Toad OpenHCSDev/toad#1159 are one paired delivery. Core head 36542eb; Toad head bc5160908139677a78305ca0b8818e7c57096fc0. Both are synced with their current mains; both published heads match ls-remote. Do not ship the Toad attachment call against a Core without this API.
An open viewer previously held the route through its entire life, and after releasing that hold it could still fail to reopen: the viewer's old interpreter cannot decode the new runtime's root. The guard is correct. The root now supplies either permission to attach or its recorded successor.
Paired Toad uses attachment.proceed before constructing Comms, sends Succeeded(runtime) to the app thread, closes the old app and execs the named runtime's toad entrypoint. It does not catch ForeignRuntimeError, compare prefixes, consult current, retry or grant an old runtime access.
Startup answer on the paired head: NO saved-tab-roster reopen yet. Toad app.py:440-444 invokes ApplicationLifetime.start; application_lifetime.py:149-157 opens home when no --session was given, otherwise only that named session. TabOrder starts with an empty _open list at tab_order.py:14. Toad #1162 is still draft; this pair does not implement its tab restoration.
Source inspection: existing refactor-audit Package.load inventoried the Core declarations/consumers and 288 Toad source modules with zero parse omissions; Textual App.exit, return_value and call_from_thread implementations were read before adapting them. These are source facts, not an execution pass. No tests or practice installs ran in Drafts. The old copied-install results in the earlier body were at older heads and are not qualification of this succession implementation.
Assumed: RootRuntimeStore records the owning prefix; the target runtime contains bin/python and the paired toad console script; the owned preparation worker invokes succession; standard app teardown retires its existing resources; tab restoration remains #1162. The review fork owns guard, outcome and paired-app execution checks.