Repository navigation
Release viewer route holds when opening and attachment finish - #1159
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 20:33
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with Core OpenHCSDev/agent-comms#2860. Core head 36542eb3cf42bce729ae3da7565e75bddc2a201d; Toad head bc51609. They land together under the commander's paired order.
An old viewer cannot read a root that a new runtime owns. Rather than turn that correct refusal into FailedObservation, the root's attachment result now hands the viewer to the recorded owner:
Startup answer: NO, this head does not reopen the saved open-tab roster. app.py:440-444 calls ApplicationLifetime.start, whose application_lifetime.py:149-157 opens home or one explicit --session. TabOrder starts empty at tab_order.py:14. #1162 is still draft and owns roster restoration; none is built here.
Both mains were merged and both published heads match ls-remote. No tests, app launch or practice install ran in Drafts; the review fork runs the pair. Earlier copied-app results used old heads: idle installs succeeded, but history remained Loading messages and replacement refused the old runtime. Those old observations do not prove this new handoff.
Assumed: succession is entered from the existing preparation worker; Textual's normal shutdown retires existing app resources; the recorded runtime contains the paired toad executable; argv/root selection survives exec through its existing arguments/environment; open-tab restoration remains #1162. The core prefix/maintenance guard remains authoritative.