Skip to content

Update current settings/form dependencies and normal dependency graph - #593

Closed
trissim wants to merge 1 commit into
mainfrom
fix/current-form-dependencies
Closed

trissim wants to merge 1 commit into
mainfrom
fix/current-form-dependencies

Conversation

@trissim

@trissim trissim commented Oct 13, 2026

Copy link
Copy Markdown

Continues the accepted #592 delivery. Updates formbridge/objectstate and the documentation-only diff-view source pin; deletes obsolete dependency-metadata overrides so published packages own their graph. Consumer source tracing and affected installed UI verification remain in progress. Original failed/UNKNOWN inputs and default runtime remain untouched. Owner: toad-close-lifecycle; integration: agent-comms-ux.

@trissim

trissim commented Oct 13, 2026

Copy link
Copy Markdown
Author

Current libraries resolve normally without either dependency-metadata override: formbridge0.1.5, objectstate4.0.1, python-introspect0.3.0, zmqruntime0.6.5, metaclass-registry0.4.0. Separate installed development prefix has 81 packages and passes uv pip check and actual Conversation/SettingsScreen imports. Existing accepted native-failure prefix is untouched.

Source census through existing ModuleSyntaxIndex: 679 production/dependency modules, zero omissions, 176 relevant declaration/call/import sites. Traced ObjectState mutation, resolved/dirty callbacks, reconstruction, mark_saved/restore_saved and ParameterFormService analysis; existing consumer APIs remain supported. Existing annotation normalization and view validation are still necessary: current nested-form discovery checks raw dataclass types, and ObjectState.update_parameter explicitly delegates conversion to the view. No compatibility wrappers or competing codec added.

Actual installed development Toad on plain st/:165 opens settings, searches the nested prompt field, edits it, applies and saves CURRENT_DEPENDENCY_SETTINGS_VERIFIED to a private copy of Tristan settings. Original settings/history/UNKNOWN unchanged. Evidence .artifacts/current-dependencies/live/ and source-census.json. Local debt ratchet passes; no automated tests run. Default publication remains blocked by Tristan live Toad2850721 retaining the existing route-directory read lease; no selectors changed. Integration owner coordinates Core/NRA source pins and publication. Draft retained for current-pin coordination and final affected installed acceptance.

@trissim

trissim commented Oct 13, 2026

Copy link
Copy Markdown
Author

Current-library verification found a real visible-update gap, not just an uncertain screenshot. The actual ObjectState restore callback restores ui.prompt_message and FormView paints the restored control value; after-refresh observation also reports the restored value and no dirty fields. Nevertheless physical st pixels retain the old edit/dirty mark until that control is focused. Evidence: .artifacts/current-dependencies/discard-live/{callbacks.jsonl,discard-finished.png,focused-settled.png}. This owner retains the diagnosis. Current-library activation is not accepted yet; no Textual source change has been made (project requires an approved plan for that fork).

Separately the already-merged #592/#746 pair is now installed: all five command links select /home/ts/.local/share/agent-comms/runtimes/toad-native-failure-final-core-47f9856b. Original route and old directories are unchanged, user Toad and Claude processes preserved. Existing directory readers protect active-route changes; my earlier exclusive lock for immutable-runtime linking was broader than needed. Used the existing shared route guard while advancing backend links before the frontend.

Actual default toad-comms on isolated display165 loads the saved fork, shows the retained failed row before the later successful reply with no stale tail, and opens the #comms channel view. .artifacts/error-placement/installed-now/ holds screenshots. Full default log-route acceptance remains open: expanded details did not show the Inspect session action at this terminal size. No provider input was repeated. No automated tests run; project test-edit/run restriction remains in force. Owned frontend/display/fork stopped after capture.

@trissim

trissim commented Oct 13, 2026

Copy link
Copy Markdown
Author

Census #593 structural PASS at 277c239; merge-base b8bda1b. Full diff +242/-42: pyproject.toml +3/-17; uv.lock +239/-25. Production Python delta: every measure +0, code lines +0. No new dispatch/isinstance chains/4+-term boolean chains, family, or saved-record member deletion; new-case edit count N/A.

Removed competing dependency metadata overrides from project and lock; normal package metadata owns transitive dependencies (TIME-7 mechanism removed). Primary pins pyproject.toml:32-33 are formbridge 0.1.5/objectstate 4.0.1; lock package entries :472-473/:1091-1092 match, with one entry each. No dependency-metadata override survives in either parsed TOML document. textual-diff-view source pin at pyproject.toml:43 matches lock :1669. Consumers inspected: preferences.py:21 owns ObjectState-backed settings; forms/form_view.py:25-44 constructs ParameterAnalysisInput through the imported formbridge service; no production consumer changes in this diff.

Deployment gap: the current installed runtime still has formbridge 0.1.0/objectstate 2.1.1. I did not install packages or claim settings/form acceptance against the new versions. Author's clean-export build must exercise actual settings open/edit/save/reopen with the updated dependency graph before live delivery.

@trissim

trissim commented Oct 16, 2026

Copy link
Copy Markdown
Author

Superseded by #670’s complete Forms/dependency cohort; its formbridge/objectstate upgrade and normal package graph replace this older pin-only branch, but #670 is still unfinished and must not be installed yet.

@trissim trissim closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant