Repository navigation
P55: New-session dialog takes model and thinking from the shared model selector - #729
Merged
Merged
Conversation
…l selector The command dialog prepares catalog-backed fields through Core (TargetAction.prepare_fields) before opening, and renders each one as a CatalogField that opens the existing model search and provider connection. ModelSwitcher's search, ranking, recents and Connect row move into a ModelSelection base; the prompt's ModelSwitcher and the dialog's CatalogFieldSelection only declare their choices, current value, selection and provider-connection actions. Lifted from forms-migration's 1b9f893 and 72ced63 on #670 without their scratch files or pins, and adapted to Core main: prepare_fields() takes no Comms, and the dialog picker is named CatalogFieldSelection so it does not shadow Core's CatalogSelection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P55: the new-session dialog asked for a pi binary, had its own model and thinking fields beside the model selector, and had both Task and Prompt boxes. Depends on Core OpenHCSDev/agent-comms#1070, which deletes
pi_binandpromptfrom New/Fork (Core only ever used Prompt as an override of Task) and declaresmodel/thinking_levelas catalog fields.Toad change:
ThreadAction.collectprepares the declared fields through Core (TargetAction.prepare_fields()) before opening the dialog, so catalog fields carry their discovered choices.CommandDialogrenders each catalog field as aCatalogFieldbutton. It opens the existing model search, with recents, ranking and "Connect a provider…" (provider login, then catalog refresh). Choosing a model refreshes the thinking catalog for that model.model_switcher.py: search, ranking, recents and the Connect row move into aModelSelectionbase. The prompt'sModelSwitcherand the dialog'sCatalogFieldSelectiondeclare only their choices, current value, what selecting does and what connecting does.Taken from forms-migration's 1b9f893 and 72ced63 on #670 without their scratch files or pins, and adapted to Core main:
prepare_fields()without Comms, and the picker is renamed so it does not shadow Core'sCatalogSelection. #670 should drop those two commits.Real UI check: isolated Xvfb :254, plain
st, isolated AGENT_COMMS_ROOT with copied sessions, this branch plus Core #1070. The dialog shows Name, Task, Tags, Project, Model and Thinking level, with no pi binary and no Prompt. Clicking Model opens the shared model search (444 models plus Connect a provider). One session,p55-dialog-check, was created and attached; its footer shows openai-codex/gpt-6.1-sol · high, and the registry stores model openai-codex/gpt-6.1-sol, thinking high and an empty task (so no input was sent). Ctrl+Q exited cleanly with no crash file. No automated tests (Toad policy).The agent-comms pin moves to the #1070 merge at install time.
🤖 Generated with Claude Code