Repository navigation
Conversation
BBQSoloFarmer::program() runs its quest rounds inline against the console, so the round logic (which quests count, when to stop, when to save) can only be exercised by running the farmer on a Switch. Move the round loop into run_bbq_rounds(), which takes the game actions it depends on as a BBQGameActions interface: read the quests, process them, do a quest, report a completed quest, and end the round (saving if due). BBQSoloFarmer implements these with the calls they replace, in the same order; the date fix, save/reset, stats and notification move together into end_round(). Startup, flying to the plaza and end-of-program handling stay in program(). The commented-out single-quest debug block declares its own egg counter now that the loop locals have moved. process_quest_list() only reads its quest list and egg count, so take them as const& and by value. Add PokemonSV::BBQFarmerRounds, a table of scenarios run against a simulated singleplayer quest panel: 3 blue quests, completed quests are replaced, impossible quests are skipped, and a panel with nothing doable is rerolled. Each scenario checks the number of completed quests and the exact action sequence: finishing the round that reaches the goal, a quest already gone, a failed quest, a panel with nothing doable, saving at exact multiples, and stopping when out of eggs. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
process_and_do_quest() gives up on a quest after NUM_RETRIES retries, but the quest stays on the panel, so the next round attempts it again with a fresh set of retries. A quest that cannot be done, such as a sneak-up whose target does not spawn, is retried forever. run_bbq_rounds() now remembers quests that failed all their attempts and leaves them out of later rounds. A quest is forgotten once a read of 4 known quests shows it gone, so it gets its attempts again if it comes back. If only failed quests are doable, the farmer stops instead of spending BP to reroll them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 21, 2026 17:51
438acb5 to
053e59b
Compare
This was referenced Oct 21, 2026
Contributor
Author
|
Closing for now to keep the upstream queue to PRs that are ready: this one waits on unmerged parent PRs. It continues on my fork as dayfine#6, and I'll reopen it here once its parents merge. |
Open
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_and_do_quest()gives up on a quest afterNUM_RETRIESretries. But the failed quest stays on the panel, so the next round attempts it again with a fresh set of retries. A quest that can't be done, such as a sneak-up whose target never spawns, is retried forever. WithNUM_RETRIES= 1 that means 2 attempts every round, indefinitely.Change
All of this is in
run_bbq_rounds();process_and_do_quest()is unchanged.do_quest()call fails (meaning it used all of its retries) is remembered as failed and left out of later rounds. WithNUM_RETRIES= 1 it gets 2 attempts in total.UnableToDetectif OCR fails, but a 4th slot only appears when OCR reads it, so a 3-slot read may have missed a quest. A missed read must not hand a failing quest new attempts.Tests
4 new
PokemonSV::BBQFarmerRoundsscenarios, run against the simulated quest panel from #1632. The fake can now have quests that never complete, and a custom list of quests that replace completed ones.All 10 farmer-round scenarios pass.
This replaces the earlier version. That version passed an optional retry tracker into
process_and_do_quest(), used forward declarations and#pragma once, and had Python replay tests that compiled pieces of production code cut out of the source by text matching. The live smoke run it reported (3 quests completed on the first attempt) never reached the failed-quest path. No live run of the failed path has been done for this version either.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E