Repository navigation
Conversation
This was referenced Oct 22, 2026
Open
dayfine
force-pushed
the
bbq/save-milestone-tracker
branch
from
October 27, 2026 06:52
f4a95b1 to
21b53ed
Compare
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 27, 2026 06:52
50a3704 to
00a5ce3
Compare
dayfine
changed the base branch from
bbq/save-milestone-tracker
to
bbq/verified-reroll
October 27, 2026 06:53
This was referenced Oct 27, 2026
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 27, 2026 19:16
7c4feb6 to
6ebb53d
Compare
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 27, 2026 19:16
00a5ce3 to
90cb78e
Compare
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 28, 2026 03:43
90cb78e to
7a7c880
Compare
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 28, 2026 03:43
6ebb53d to
99d6497
Compare
process_and_do_quest() gives up on a quest after NUM_RETRIES retries, but the quest stays on the panel, so the next round attempts it again with a fresh set of retries. A quest that cannot be done, such as a sneak-up whose target does not spawn, is retried forever. run_bbq_rounds() now remembers quests that failed all their attempts and leaves them out of later rounds. A quest is forgotten once a read of 4 known quests shows it gone, so it gets its attempts again if it comes back. If only failed quests are doable, the farmer stops instead of spending BP to reroll them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 28, 2026 08:14
99d6497 to
e6afd5e
Compare
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 28, 2026 08:14
7a7c880 to
6e412fc
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
process_and_do_quest()gives up on a quest afterNUM_RETRIESretries. But the failed quest stays on the panel, so the next round attempts it again with a fresh set of retries. A quest that can't be done, such as a sneak-up whose target never spawns, is retried forever. WithNUM_RETRIES= 1 that means 2 attempts every round, indefinitely.Change
All of this is in
run_bbq_rounds();process_and_do_quest()is unchanged.do_quest()call fails (meaning it used all of its retries) is remembered as failed and left out of later rounds. WithNUM_RETRIES= 1 it gets 2 attempts in total.UnableToDetectif OCR fails, but a 4th slot only appears when OCR reads it, so a 3-slot read may have missed a quest. A missed read must not hand a failing quest new attempts.Tests
4 new
PokemonSV::BBQFarmerRoundsscenarios, run against the simulated quest panel from PokemonAutomation#1632. The fake can now have quests that never complete, and a custom list of quests that replace completed ones.All 10 farmer-round scenarios pass.
This replaces the earlier version. That version passed an optional retry tracker into
process_and_do_quest(), used forward declarations and#pragma once, and had Python replay tests that compiled pieces of production code cut out of the source by text matching. The live smoke run it reported (3 quests completed on the first attempt) never reached the failed-quest path. No live run of the failed path has been done for this version either.Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. A failed quest staying on the panel did not come up (each failure was rerolled first); covered by the BBQFarmerRounds tests.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E