Repository navigation
Conversation
This was referenced Oct 27, 2026
dayfine
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/quest-planner
branch
from
October 28, 2026 03:43
f4b2be7 to
5e35b96
Compare
dayfine
force-pushed
the
bbq/pin-stuck-rounds
branch
from
October 28, 2026 03:43
e326a90 to
0725fc7
Compare
The round loop has several ways to stop making progress or lose time, and the PRs that fix them each change its behavior. Without a test of the current behavior, a reviewer has to infer from the code what each fix changes. Add BBQFarmerRounds scenarios that state what the loop does today: a failed quest is attempted again every round; a panel whose only doable quest keeps failing is retried forever; rerolls that change nothing (out of BP) repeat forever; a round that skips past a save milestone does not save; and a round with no completions saves because 0 is a multiple of the interval. Each fix then shows up as a change to one of these expectations. The simulated panel gains quests that never complete, an out-of-BP mode where rerolls do nothing, and a read limit per scenario; a run that exceeds it is recorded as "stuck". Test-only; no behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/quest-planner
branch
from
October 28, 2026 08:14
5e35b96 to
ab57d3e
Compare
dayfine
force-pushed
the
bbq/pin-stuck-rounds
branch
from
October 28, 2026 08:14
0725fc7 to
037549e
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
The BBQ Farmer's round loop has a few ways to stall or waste time, and the PRs after this one fix them, but nothing showed what the loop does today. This adds
BBQFarmerRoundsscenarios that state the current behavior: a failed quest is retried every round, a panel whose only doable quest keeps failing is retried forever, rerolls that change nothing (out of BP) repeat forever, a round that skips past a save milestone doesn't save, and a round with no completions saves anyway. The simulated panel gains quests that never complete, an out-of-BP mode and a read limit that marks a run as stuck. Each later fix (#6, #5, #4) replaces one of these scenarios in place, so its diff shows the behavior change. Test-only; 29 BBQ tests pass.Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. Test-only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E