Skip to content

BBQ Farmer: pin the ways the round loop gets stuck today - #53

Closed
dayfine wants to merge 6 commits into
bbq/quest-plannerfrom
bbq/pin-stuck-rounds
Closed

dayfine wants to merge 6 commits into
bbq/quest-plannerfrom
bbq/pin-stuck-rounds

Conversation

@dayfine

@dayfine dayfine commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Stage 1 ("never stuck"), PR 3 of 9. Based on bbq/quest-planner (#38), so the diff shows only this change. Parents: #38 → #37 → #51 → main.

Part of PokemonAutomation/ComputerControl#263.

The BBQ Farmer's round loop has a few ways to stall or waste time, and the PRs after this one fix them, but nothing showed what the loop does today. This adds BBQFarmerRounds scenarios that state the current behavior: a failed quest is retried every round, a panel whose only doable quest keeps failing is retried forever, rerolls that change nothing (out of BP) repeat forever, a round that skips past a save milestone doesn't save, and a round with no completions saves anyway. The simulated panel gains quests that never complete, an out-of-BP mode and a read limit that marks a run as stuck. Each later fix (#6, #5, #4) replaces one of these scenarios in place, so its diff shows the behavior change. Test-only; 29 BBQ tests pass.

Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. Test-only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

The round loop has several ways to stop making progress or lose time,
and the PRs that fix them each change its behavior. Without a test of
the current behavior, a reviewer has to infer from the code what each
fix changes.

Add BBQFarmerRounds scenarios that state what the loop does today: a
failed quest is attempted again every round; a panel whose only doable
quest keeps failing is retried forever; rerolls that change nothing
(out of BP) repeat forever; a round that skips past a save milestone
does not save; and a round with no completions saves because 0 is a
multiple of the interval. Each fix then shows up as a change to one of
these expectations.

The simulated panel gains quests that never complete, an out-of-BP mode
where rerolls do nothing, and a read limit per scenario; a run that
exceeds it is recorded as "stuck". Test-only; no behavior change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine force-pushed the bbq/pin-stuck-rounds branch from 0725fc7 to 037549e Compare October 28, 2026 08:14
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 1 PR #272.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the bbq/pin-stuck-rounds branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant