Skip to content

BBQ Farmer: let a quest that fails all its retries be rerolled or stop the program - #10

Closed
dayfine wants to merge 7 commits into
bbq/save-reset-milestonesfrom
bbq/exhausted-quest-actions
Closed

dayfine wants to merge 7 commits into
bbq/save-reset-milestonesfrom
bbq/exhausted-quest-actions

Conversation

@dayfine

@dayfine dayfine commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Stage 1 ("never stuck"), PR 8 of 9. Based on bbq/save-reset-milestones (#4), so the diff shows only this change. Parents: #4 → #5 → #6 → #8 → #53 → #38 → #37 → #51 → main.

Part of PokemonAutomation/ComputerControl#263.

With #6, a quest that fails all its retries is skipped while it stays on the panel. That keeps the farmer going, but the quest blocks its slot, and once every doable quest is one that failed, the farmer stops.

Change

A new option, Out of Retries, chooses what happens when a quest fails all its retries:

Option Behavior
Skip (default) Same as #6: not attempted again while it stays on the panel.
Reroll Reroll the failed quest so its slot gets a new one. Costs BP.
Stop End the program there, through the normal end of program (go home, fix time, finish notification).

Tests

2 new PokemonSV::BBQFarmerRounds cases: Reroll (the failed quest is replaced and its replacement is attempted the next round) and Stop. The existing cases run with the Skip default. All 30 BBQ cases pass.

Codex's earlier version of this PR is kept in the local branch backup/exhausted-quest-actions-codex. Compared with it:

Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. With Out of retries: Reroll, 3 quests that failed their retry were rerolled and replaced.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

A quest that fails all its retries is skipped while it stays on the
panel. That keeps the farmer going, but the quest blocks its slot, and
if every doable quest is one that failed the farmer stops.

OUT_OF_RETRIES now chooses what happens:

- Skip (default): as before.
- Reroll: reroll the failed quest, so its slot gets a new quest. Uses
  reroll_quest_slot(), which checks which quest it pays for and that it
  was replaced.
- Stop: end the program there, through the normal end of program.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 1 PR #272.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the bbq/exhausted-quest-actions branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant