Repository navigation
Conversation
This was referenced Oct 22, 2026
Open
Closed
dayfine
force-pushed
the
bbq/quest-planner
branch
from
October 27, 2026 06:52
19e0c6b to
f4b2be7
Compare
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 27, 2026 06:52
84800b2 to
7c4feb6
Compare
This was referenced Oct 27, 2026
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 27, 2026 19:16
7c4feb6 to
6ebb53d
Compare
dayfine
changed the base branch from
bbq/quest-planner
to
bbq/pin-stuck-rounds
October 27, 2026 19:16
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 28, 2026 03:43
6ebb53d to
99d6497
Compare
reroll_slot() opened the quest panel, pressed DOWN once per slot from where it assumed the cursor was, and pressed A twice. The panel does not always open with the cursor on the top quest: on a Switch it opened where the cursor was left, so the reroll paid for a different quest than planned. Nothing checked the menu opened or the quest changed, so running out of BP went unnoticed and the same quest was rerolled every round. reroll_quest() now does a reroll through injectable BBQRerollActions: open the reroll menu wherever the cursor is, see which quest the menu opened next to from its arrow, move to the planned quest, and only then confirm. Afterwards it reads the panel (up to 3 times, as OCR can miss a read) to check the quest was replaced. Panel or menu not found stops before spending BP; a quest not replaced stops without an error report, as it usually means out of BP. The arrow boxes for the top three slots were checked on a Switch; the fourth uses the same spacing. Reroll-all is unchanged. reroll_slot() becomes reroll_quest_slot(), declared next to reroll_quest(): it runs reroll_quest() on the console and stops the program if the reroll fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/pin-stuck-rounds
branch
from
October 28, 2026 08:14
0725fc7 to
037549e
Compare
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 28, 2026 08:14
99d6497 to
e6afd5e
Compare
# Conflicts: # SerialPrograms/Source/VideoGames/PokemonSV/Programs/Farming/PokemonSV_BBQTests.cpp
Windows Clang builds with -Werror,-Wmissing-designated-field-initializers, and the scenarios leave these fields out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This was referenced Nov 6, 2026
This was referenced Nov 6, 2026
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
Rerolling a quest costs BP, but the farmer did not check which quest it paid for, or whether anything was rerolled at all.
reroll_slot()opened the quest panel and pressed DOWN once per slot, assuming the cursor started on the top quest. On a Switch the panel often opens with the cursor where it was left. In one run, 3 of 10 rerolls opened the menu on a different quest than planned.Change
reroll_quest()does one reroll through an injectableBBQRerollActions:reroll_slot()becomesreroll_quest_slot(), declared next toreroll_quest(), which runs it on the console and stops the program if it fails:Reroll-all is unchanged.
Limits
Tests
9
PokemonSV::BBQRerollcases runreroll_quest()against a simulated panel with a cursor. Each checks the result, which slots were paid for, the updated quests, and that the panel was closed. They cover the cursor left below the quest, the fourth quest, panel or menu not found, out of BP, missed reads, and a same-quest replacement. All pass, along with the existingPokemonSV::BBQuestPlancases.Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. All 7 rerolls hit the intended slot and were confirmed replaced.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E