Repository navigation
Conversation
This was referenced Oct 22, 2026
Closed
Open
dayfine
force-pushed
the
bbq/endless-reroll-guard
branch
from
October 27, 2026 06:52
f62d994 to
e1a20c2
Compare
dayfine
force-pushed
the
bbq/save-milestone-tracker
branch
from
October 27, 2026 06:52
f4a95b1 to
21b53ed
Compare
dayfine
changed the base branch from
bbq/save-milestone-tracker
to
bbq/persistent-quest-retries
October 27, 2026 06:53
This was referenced Oct 27, 2026
dayfine
force-pushed
the
bbq/endless-reroll-guard
branch
from
October 27, 2026 19:16
e1a20c2 to
b4bc0f0
Compare
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 27, 2026 19:16
00a5ce3 to
90cb78e
Compare
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 28, 2026 03:43
90cb78e to
7a7c880
Compare
dayfine
force-pushed
the
bbq/endless-reroll-guard
branch
from
October 28, 2026 03:43
b4bc0f0 to
4fd705d
Compare
When nothing on the panel is doable the farmer rerolls it and reads it again. If nothing can ever become doable, the loop never ends. Check at start that the exclusions table leaves at least one doable blue quest, and give up with a UserSetupError after 30 reads in a row with nothing doable (wrong game language, or no BP left to reroll). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/persistent-quest-retries
branch
from
October 28, 2026 08:14
7a7c880 to
6e412fc
Compare
dayfine
force-pushed
the
bbq/endless-reroll-guard
branch
from
October 28, 2026 08:14
4fd705d to
e3ef02c
Compare
dayfine
added a commit
that referenced
this pull request
Nov 2, 2026
After the lake, the Lakefront's frame script walks the player 3 south, to (17, 14) or a tile below (decomp, event timeline 00.02 #5), not onto the entrance (17, 12). 00.02's end and 00.03's start take either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
When nothing on the quest panel is doable, the BBQ Farmer rerolls the whole panel and reads it again. If nothing can ever become doable, it does this forever, spending BP on every reroll. This PR stops the program with a setup error in that case.
Change
run_bbq_rounds()throwsUserSetupErrorbefore reading the panel if the exclusions table skips or rerolls every blue quest the program can do (blue quests minusnot_possible_quests). A quest counts as doable when any table row for it says Run, which matches howprocess_quest_list()treats duplicate rows.UserSetupErrortelling the user to check the game language and their BP. If the language is wrong, every quest reads asUnableToDetect. If BP runs out, rerolls stop changing the panel.Why 30: with valid settings, a panel can have nothing doable and the next reroll fixes it. In a bad case where only 3 of the 31 blue quests are doable, a panel has nothing doable 73% of the time, so 30 such panels in a row happen with probability 0.008%. With the defaults (28 doable) the chance per panel is 0.02%.
Tests
There are 3 new
PokemonSV::BBQFarmerRoundsscenarios that run through the simulated quest panel from PokemonAutomation#1632. The panel can now be out of BP, meaning rerolls do nothing.All 9 farmer-round scenarios pass. Without this change, the first and third scenarios fail.
Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. Giving up on rerolls needs an empty BP balance, so it is covered by the BBQFarmerRounds tests only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E