Skip to content

BBQ Farmer: save once when completion milestones advance - #4

Closed
dayfine wants to merge 7 commits into
bbq/endless-reroll-guardfrom
bbq/save-reset-milestones
Closed

dayfine wants to merge 7 commits into
bbq/endless-reroll-guardfrom
bbq/save-reset-milestones

Conversation

@dayfine

@dayfine dayfine commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Stage 1 ("never stuck"), PR 7 of 9. Based on bbq/endless-reroll-guard (#5), so the diff shows only this change. Parents: #5 → #6 → #8 → #53 → #38 → #37 → #51 → main.

The BBQ Farmer saves and resets when the completion count is an exact multiple of the save interval. That has two problems:

  • A round that completes nothing while the count sits at 0 or 50 saves and resets again.
  • A round that goes from 49 to 52 completions skips the 50 milestone entirely.

Changes

  • run_bbq_rounds() compares the completion count before and after each round, and asks end_round() to save once when the count crosses a multiple of the interval. Stalled rounds and an interval of 0 never save. The check is a file-local helper in BBQSoloFarmer.cpp.
  • The save/reset steps themselves are unchanged.
  • Fix the option label to say "after completing this many quests" instead of "attempting".

Validation

Recovery context: PokemonAutomation/ComputerControl#263.

Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. With "save every 2 quests" it saved at 2, 4 and 7 completions; 7 crossed the milestone at 6 without landing on it.

🤖 Generated with Claude Code

The farmer saved and reset when the completion count was an exact
multiple of SAVE_NUM_QUESTS. A round that completed nothing while the
count sat at 0 or 50 saved again, and a round going from 49 to 52
skipped the 50 milestone entirely.

Compare the count before and after each round and ask end_round() to
save once when it crosses a multiple of the interval. Stalled rounds
and an interval of 0 never save. Fix the option label to say
"completing", not "attempting".

Add two PokemonSV::BBQFarmerRounds scenarios that fail with the old
rule: a round that skips past a milestone, and rounds with no
completions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine force-pushed the bbq/endless-reroll-guard branch from 4fd705d to e3ef02c Compare October 28, 2026 08:14
@dayfine
dayfine force-pushed the bbq/save-reset-milestones branch from 77bcaa5 to 30063b3 Compare October 28, 2026 08:14
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 1 PR #272.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the bbq/save-reset-milestones branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant