Repository navigation
Conversation
This was referenced Oct 22, 2026
Closed
dayfine
force-pushed
the
bbq/save-reset-milestones
branch
from
October 27, 2026 06:52
548ac95 to
df9c3e3
Compare
dayfine
force-pushed
the
bbq/save-milestone-tracker
branch
from
October 27, 2026 06:52
f4a95b1 to
21b53ed
Compare
dayfine
changed the base branch from
bbq/save-milestone-tracker
to
bbq/endless-reroll-guard
October 27, 2026 06:53
This was referenced Oct 27, 2026
dayfine
force-pushed
the
bbq/endless-reroll-guard
branch
from
October 27, 2026 19:16
e1a20c2 to
b4bc0f0
Compare
dayfine
force-pushed
the
bbq/save-reset-milestones
branch
from
October 27, 2026 19:16
df9c3e3 to
0bcd807
Compare
dayfine
force-pushed
the
bbq/save-reset-milestones
branch
from
October 28, 2026 03:43
0bcd807 to
77bcaa5
Compare
dayfine
force-pushed
the
bbq/endless-reroll-guard
branch
from
October 28, 2026 03:43
b4bc0f0 to
4fd705d
Compare
The farmer saved and reset when the completion count was an exact multiple of SAVE_NUM_QUESTS. A round that completed nothing while the count sat at 0 or 50 saved again, and a round going from 49 to 52 skipped the 50 milestone entirely. Compare the count before and after each round and ask end_round() to save once when it crosses a multiple of the interval. Stalled rounds and an interval of 0 never save. Fix the option label to say "completing", not "attempting". Add two PokemonSV::BBQFarmerRounds scenarios that fail with the old rule: a round that skips past a milestone, and rounds with no completions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/endless-reroll-guard
branch
from
October 28, 2026 08:14
4fd705d to
e3ef02c
Compare
dayfine
force-pushed
the
bbq/save-reset-milestones
branch
from
October 28, 2026 08:14
77bcaa5 to
30063b3
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BBQ Farmer saves and resets when the completion count is an exact multiple of the save interval. That has two problems:
Changes
run_bbq_rounds()compares the completion count before and after each round, and asksend_round()to save once when the count crosses a multiple of the interval. Stalled rounds and an interval of 0 never save. The check is a file-local helper inBBQSoloFarmer.cpp.Validation
PokemonSV::BBQFarmerRoundsscenarios run the farmer loop against BBQ Farmer: run rounds against injectable BBQGameActions PokemonAutomation/Arduino-Source#1632's simulated quest panel: a round that skips past a milestone, and rounds with no completions. Both fail with the old rule and pass with the fix. BBQ Farmer: run rounds against injectable BBQGameActions PokemonAutomation/Arduino-Source#1632's other scenarios still pass.Recovery context: PokemonAutomation/ComputerControl#263.
Tested on the Switch with the rest of stage 1 in runs S1b and S1c (STAGE_RUNS.md): 15 quests, no stretch over 11 min without a completion, BP check OK. With "save every 2 quests" it saved at 2, 4 and 7 completions; 7 crossed the milestone at 6 without landing on it.
🤖 Generated with Claude Code